Page MenuHomePhabricator
Differential D6078

[keyserver] Pass `calendarQuery` to `processSuccessfulLogin` in `siweAuthResponder`
ClosedPublic
Actions

Authored by atul on Dec 28 2022, 7:20 PM.
Tags
None
Referenced Files
F2191739: D6078.id20287.diff
Thu, Jul 4, 5:06 PM
F2187831: D6078.id20287.diff
Thu, Jul 4, 7:14 AM
Unknown Object (File)
Wed, Jul 3, 12:51 AM
Unknown Object (File)
Mon, Jul 1, 9:11 PM
Unknown Object (File)
Sat, Jun 29, 11:03 PM
Unknown Object (File)
Wed, Jun 26, 12:40 AM
Unknown Object (File)
Wed, Jun 26, 12:40 AM
Unknown Object (File)
Wed, Jun 26, 12:40 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM8f338e90b288: [keyserver] Pass `calendarQuery` to `processSuccessfulLogin` in…
Summary

Context: https://linear.app/comm/issue/ENG-2575/pass-calendarquery-up-from-client-to-siweauthresponder

https://phab.comm.dev/D6060#inline-40815

Should have done this earlier... calendarQuery was already being included in SIWEAuthRequest.

Depends on D6077

Test Plan

Set breakpoints and observed that calendarQuery "made it" to processSuccessfulLogin as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 28 2022, 7:20 PM
atul published this revision for review.Dec 28 2022, 7:21 PM
ashoat requested changes to this revision.Dec 28 2022, 7:25 PM

How about the native side to send this field up?

keyserver/src/responders/user-responders.js
337 ↗(On Diff #20276)

It shouldn't be optional. It's only optional for other responders to support old clients

This revision now requires changes to proceed.Dec 28 2022, 7:25 PM
atul added inline comments.Dec 28 2022, 7:31 PM
keyserver/src/responders/user-responders.js
337 ↗(On Diff #20276)

Ah gotcha, updating

atul updated this revision to Diff 20278.Dec 28 2022, 7:34 PM

address feedback

Harbormaster completed remote builds in B14866: Diff 20276.Dec 28 2022, 7:34 PM
atul added a comment.Dec 28 2022, 7:35 PM

How about the native side to send this field up?

calendarQuery is already a required field of SIWEAuthServerCall.

atul updated this revision to Diff 20279.Dec 28 2022, 7:37 PM

don't include normalizeCalendarQuery as a step

Harbormaster completed remote builds in B14868: Diff 20278.Dec 28 2022, 7:47 PM
Harbormaster completed remote builds in B14869: Diff 20279.Dec 28 2022, 7:50 PM
ashoat accepted this revision.Dec 28 2022, 8:27 PM
This revision is now accepted and ready to land.Dec 28 2022, 8:27 PM
atul updated this revision to Diff 20286.Dec 28 2022, 10:33 PM

rebase around D6077 before landing

Harbormaster completed remote builds in B14873: Diff 20286.Dec 28 2022, 10:46 PM
Closed by commit rCOMM8f338e90b288: [keyserver] Pass `calendarQuery` to `processSuccessfulLogin` in… (authored by atul). · Explain WhyDec 28 2022, 11:43 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8f338e90b288: [keyserver] Pass `calendarQuery` to `processSuccessfulLogin` in….
atul mentioned this in D6077: [keyserver] Introduce `createSIWEAccount` and use in `siweAuthResponder`.Dec 29 2022, 12:06 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
5 lines

Diff 20287

View Options

keyserver/src/responders/user-responders.js

Loading...