Page MenuHomePhabricator
Differential D6085

[lib] Modify `siweAuth(...)` return type from `LogInResponse` to `LogInResult`
ClosedPublic
Actions

Authored by atul on Dec 29 2022, 1:23 AM.
Tags
None
Referenced Files
F2189752: D6085.diff
Thu, Jul 4, 10:59 AM
F2189366: D6085.diff
Thu, Jul 4, 10:37 AM
Unknown Object (File)
Wed, Jun 26, 12:41 AM
Unknown Object (File)
Wed, Jun 26, 12:41 AM
Unknown Object (File)
Wed, Jun 26, 12:41 AM
Unknown Object (File)
Wed, Jun 26, 12:41 AM
Unknown Object (File)
Wed, Jun 26, 12:40 AM
Unknown Object (File)
Wed, Jun 26, 12:35 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM55ce73655587: [lib] Modify `siweAuth(...)` return type from `LogInResponse` to `LogInResult`
Summary

We construct LogInResult using the request payload (SIWEAuthServerCall) and the respond (LogInResponse). Code was effectively cut/paste from lib/actions/user-actions:logIn.

Depends on D6077

Test Plan

Will be tested implicitly by subsequent diffs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 29 2022, 1:23 AM
atul added a child revision: D6086: [lib] Add `siweAuthActionTypes.success` check everywhere there's a `logInActionTypes.success` check.
Harbormaster completed remote builds in B14880: Diff 20295.Dec 29 2022, 1:36 AM
atul requested review of this revision.Dec 29 2022, 1:36 AM
tomek accepted this revision.Dec 29 2022, 4:24 AM
tomek added inline comments.
lib/actions/siwe-actions.js
4–5 ↗(On Diff #20295)

We can merge these imports

This revision is now accepted and ready to land.Dec 29 2022, 4:24 AM
ashoat accepted this revision.Dec 29 2022, 9:24 AM
atul updated this revision to Diff 20396.Dec 29 2022, 2:00 PM

rebase before landing

atul updated this revision to Diff 20397.Dec 29 2022, 2:03 PM

address feedback from @tomek

atul added inline comments.Dec 29 2022, 2:04 PM
lib/actions/siwe-actions.js
4–5 ↗(On Diff #20295)

Thanks for catching that!

This revision was landed with ongoing or failed builds.Dec 29 2022, 2:07 PM
Closed by commit rCOMM55ce73655587: [lib] Modify `siweAuth(...)` return type from `LogInResponse` to `LogInResult` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM55ce73655587: [lib] Modify `siweAuth(...)` return type from `LogInResponse` to `LogInResult`.
Harbormaster completed remote builds in B14951: Diff 20396.Dec 29 2022, 2:12 PM
Harbormaster completed remote builds in B14952: Diff 20397.Dec 29 2022, 2:16 PM

Revision Contents
Changeset List

PathSize
lib/
actions/
30 lines
1 line
types/
1 line
3 lines

Diff 20398

View Options

lib/actions/siwe-actions.js

Loading...
View Options

lib/actions/user-actions.js

Loading...
View Options

lib/types/account-types.js

Loading...
View Options

lib/types/redux-types.js

Loading...