[landing][keyserver] Allow setting Alchemy key in keyserver/.env
ClosedPublic
Actions

Authored by ashoat on Dec 30 2022, 7:57 AM.

Details

Reviewers

atul

Commits

rCOMMc45ad37fa61c: [landing][keyserver] Allow setting Alchemy key in keyserver/.env

Summary

This will get downloaded to clients and isn't obfuscated or anything.

We prefer to have clients call Alchemy directly so we don't get any unnecessary user data.

If we end up concerned later that somebody is stealing our API key, we can reset it to another one and roll out some better obfuscation via a Webpack plugin or something.

Depends on D6112

Task is ENG-1282

Test Plan

I tested the Docker keyserver build, setting COMM_ALCHEMY_KEY in keyserver/.env and making sure that the key was set in both server-side and client-side rendering contexts

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 30 2022, 7:57 AM

Herald added a subscriber: tomek. · View Herald TranscriptDec 30 2022, 7:57 AM

ashoat added inline comments.Dec 30 2022, 7:59 AM

keyserver/Dockerfile
23 ↗	(On Diff #20440)	This causes `$COMM_ALCHEMY_KEY` is be available as an env var to all of the build commands below
keyserver/docker-compose.yml
10 ↗	(On Diff #20440)	This pulls the env variable `COMM_ALCHEMY_KEY` (from `env_file` below) and declares it as an arg for the `Dockerfile` above
landing/.eslintrc.json
6 ↗	(On Diff #20440)	Without this change ESLint was erroring on our use of `process.env`. We have the same thing in `web`
landing/webpack.config.cjs
82 ↗	(On Diff #20440)	Here we pass the env variable from the build into both SSR and browser bundles via `webpack.DefinePlugin`

Harbormaster completed remote builds in B14980: Diff 20440.Dec 30 2022, 8:12 AM

ashoat requested review of this revision.Dec 30 2022, 8:12 AM

ashoat edited the summary of this revision. (Show Details)Dec 30 2022, 8:18 AM

ashoat added a child revision: D6114: [lib] Include COMM_ALCHEMY_KEY in web Webpack build as well.Dec 30 2022, 8:20 AM

Little hesitant about this approach where the key is hardcoded in (even if obfuscated)... but if it's solely for rate limiting and doesn't grant any additional permissions or anything I guess it's fine

This revision is now accepted and ready to land.Dec 30 2022, 11:41 AM

Closed by commit rCOMMc45ad37fa61c: [landing][keyserver] Allow setting Alchemy key in keyserver/.env (authored by ashoat). · Explain WhyDec 30 2022, 5:19 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMc45ad37fa61c: [landing][keyserver] Allow setting Alchemy key in keyserver/.env.