[lib] Include COMM_ALCHEMY_KEY in web Webpack build as well
ClosedPublic
Actions

Authored by ashoat on Dec 30 2022, 4:20 PM.

Details

Reviewers

atul

Commits

rCOMM0f079fec2c9a: [lib] Include COMM_ALCHEMY_KEY in web Webpack build as well

Summary

In D6113 we add process.env.COMM_ALCHEMY_KEY to be accessible from landing. But for ENG-1969, we'll need the same key available in the web build. This diff moves the logic to lib/webpack/shared.cjs so all Webpack bundles have access.

Depends on D6113

Test Plan

Tested together with later diffs in the stack

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 30 2022, 4:20 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 30 2022, 4:20 PM

Harbormaster completed remote builds in B14981: Diff 20448.Dec 30 2022, 4:31 PM

ashoat requested review of this revision.Dec 30 2022, 4:31 PM

Very limited experience with webpack, but the changes make sense + look reasonable.

This revision is now accepted and ready to land.Dec 30 2022, 9:56 PM

Closed by commit rCOMM0f079fec2c9a: [lib] Include COMM_ALCHEMY_KEY in web Webpack build as well. · Explain WhyDec 31 2022, 1:19 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM0f079fec2c9a: [lib] Include COMM_ALCHEMY_KEY in web Webpack build as well.

Revision Contents
Changeset List

Path

Size

landing/

webpack.config.cjs

32 lines

lib/

webpack/

shared.cjs

13 lines

Diff 20466

View Options

landing/webpack.config.cjs