Paths

Table of Contentst

[desktop] Enable flow in the desktop workspace
ClosedPublic
Actions

Authored by michal on Jan 5 2023, 12:33 PM.

Details

Reviewers

tomek
atul
ashoat

Commits

rCOMMe1af827cf64f: [desktop] Enable flow in the desktop workspace

Summary

ENG-2219
Adds flow support in the desktop workspace.

Test Plan

Run flow in desktop
Check if lint-staged fails when trying to commit file with type errors

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Jan 5 2023, 12:33 PM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 5 2023, 12:34 PM

Remove lib from dependencies (it was supposed to be in a next diff)

Harbormaster completed remote builds in B15116: Diff 20611.Jan 5 2023, 12:48 PM

Harbormaster completed remote builds in B15117: Diff 20612.Jan 5 2023, 12:50 PM

michal requested review of this revision.Jan 5 2023, 12:50 PM

michal added a child revision: D6175: [desktop] Type bridge object between desktop and web.Jan 5 2023, 12:53 PM

We should add this Flow check to CI: .buildkite/eslint_flow_jest.yml and .github/workflows/eslint_flow_jest.yml

desktop/package.json
37 ↗	(On Diff #20612)	We should also add `flow-typed`
desktop/src/main.js
1 ↗	(On Diff #20612)	Please add a newline below here
desktop/src/preload.js
1 ↗	(On Diff #20612)	Please add a newline below here

This revision now requires changes to proceed.Jan 5 2023, 4:28 PM

Add flow-typed dep, add newlines, add to GitHub and Buildkite CI.

Harbormaster completed remote builds in B15146: Diff 20654.Jan 9 2023, 10:38 AM

ashoat accepted this revision.Jan 9 2023, 4:24 PM

This revision is now accepted and ready to land.Jan 9 2023, 4:24 PM

Closed by commit rCOMMe1af827cf64f: [desktop] Enable flow in the desktop workspace. · Explain WhyJan 11 2023, 3:10 PM

This revision was automatically updated to reflect the committed changes.

Restricted Repository Identity added a commit: rCOMMe1af827cf64f: [desktop] Enable flow in the desktop workspace.

Revision Contents
Changeset List

Path

Size

.buildkite/

eslint_flow_jest.yml

2 lines

.github/

workflows/

eslint_flow_jest.yml

4 lines

.lintstagedrc.js

3 lines

desktop/

.eslintrc.json

3 lines

.flowconfig

29 lines

babel.config.cjs

1 line

flow-typed/

npm/

electron_vx.x.x.js

19 lines

forge.config.cjs

8 lines

package.json

2 lines

src/

handle-squirrel-event.js

4 lines

main.js

2 lines

preload.js

2 lines

native/

.flowconfig

1 line

Diff 20795

View Options

.buildkite/eslint_flow_jest.yml

View Options

.github/workflows/eslint_flow_jest.yml

View Options

.lintstagedrc.js

View Options

desktop/.eslintrc.json

View Options

desktop/.flowconfig

View Options

desktop/babel.config.cjs

View Options

desktop/flow-typed/npm/electron_vx.x.x.js

View Options

desktop/forge.config.cjs

View Options

desktop/package.json

View Options

desktop/src/handle-squirrel-event.js

View Options

desktop/src/main.js

View Options

desktop/src/preload.js

View Options

[desktop] Enable flow in the desktop workspaceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20795

.buildkite/eslint_flow_jest.yml

.github/workflows/eslint_flow_jest.yml

.lintstagedrc.js

desktop/.eslintrc.json

desktop/.flowconfig

desktop/babel.config.cjs

desktop/flow-typed/npm/electron_vx.x.x.js

desktop/forge.config.cjs

desktop/package.json

desktop/src/handle-squirrel-event.js

desktop/src/main.js

desktop/src/preload.js

native/.flowconfig

[desktop] Enable flow in the desktop workspace
ClosedPublic
Actions

Revision Contents
Changeset List