Page MenuHomePhabricator
Differential D6219

[web] Add `<hr />` in `LogInForm` to separate out "password" and SIWE options
ClosedPublic
Actions

Authored by atul on Jan 10 2023, 1:29 PM.
Tags
None
Referenced Files
F3254254: D6219.diff
Fri, Nov 15, 7:36 PM
Unknown Object (File)
Sat, Nov 9, 4:23 PM
Unknown Object (File)
Sat, Nov 9, 3:49 PM
Unknown Object (File)
Sat, Nov 9, 3:35 PM
Unknown Object (File)
Sat, Nov 9, 12:03 PM
Unknown Object (File)
Sat, Nov 9, 8:49 AM
Unknown Object (File)
Sat, Nov 9, 6:32 AM
Unknown Object (File)
Tue, Nov 5, 4:28 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMca1a049693a1: [web] Add `<hr />` in `LogInForm` to separate out "password" and SIWE options
Summary

Add a <hr /> to separate out "password" and SIWE auth options.

These designs are not final, just matching what's on native as closely as possible for now.

Depends on D6218

Test Plan

Looks as expected:

b25e14.png (1×1 px, 201 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 10 2023, 1:29 PM
atul published this revision for review.Jan 10 2023, 1:32 PM
atul edited the test plan for this revision. (Show Details)
atul edited the test plan for this revision. (Show Details)
atul updated this revision to Diff 20762.Jan 10 2023, 1:34 PM

tweak padding

Harbormaster completed remote builds in B15231: Diff 20761.Jan 10 2023, 1:44 PM
Harbormaster completed remote builds in B15232: Diff 20762.Jan 10 2023, 1:48 PM
atul edited the summary of this revision. (Show Details)Jan 10 2023, 2:29 PM
atul added a parent revision: D6218: [web] Add `siweButton` to `LogInForm` component.
atul added a child revision: D6220: [patch] Patch `@rainbow-me/rainbowkit` to increase width of formatted address.
ashoat accepted this revision.Jan 10 2023, 7:15 PM
This revision is now accepted and ready to land.Jan 10 2023, 7:15 PM
atul updated this revision to Diff 20818.Jan 11 2023, 2:25 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jan 11 2023, 2:37 PM
Closed by commit rCOMMca1a049693a1: [web] Add `<hr />` in `LogInForm` to separate out "password" and SIWE options (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMca1a049693a1: [web] Add `<hr />` in `LogInForm` to separate out "password" and SIWE options.
Harbormaster completed remote builds in B15265: Diff 20818.Jan 11 2023, 2:40 PM

Revision Contents
Changeset List

PathSize
web/
account/
18 lines
23 lines

Diff 20762

View Options

web/account/log-in-form.css

Loading...
View Options

web/account/log-in-form.react.js

Loading...