Paths

Table of Contentst

native] rename InlineSidebar to InlineEngagement
ClosedPublic
Actions

Authored by ginsu on Jan 17 2023, 6:44 PM.

Details

Reviewers

atul
tomek

Commits

rCOMM33b8b45d36e6: [lib/web/native] rename InlineSidebar to InlineEngagement

Summary

rename InlineSidebar to InlineEngagement

Linear Task: ENG-2508

Test Plan

flow also git grep inline-sidebar git grep inlineSidebar and git grep InlineSidebar

Diff Detail

Repository

rCOMM Comm

Branch

eng-2465

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 17 2023, 6:44 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 17 2023, 6:44 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 17 2023, 6:45 PM

Harbormaster failed remote builds in B15419: Diff 21024!

ginsu edited the summary of this revision. (Show Details)Jan 17 2023, 6:48 PM

ginsu added reviewers: atul, tomek.

Harbormaster completed remote builds in B15419: Diff 21024.Jan 17 2023, 6:58 PM

ginsu requested review of this revision.Jan 17 2023, 6:58 PM

Didn't look too carefully, but looks right and trust Test Plan

This revision is now accepted and ready to land.Jan 17 2023, 10:23 PM

Closed by commit rCOMM33b8b45d36e6: [lib/web/native] rename InlineSidebar to InlineEngagement. · Explain WhyJan 18 2023, 5:10 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM33b8b45d36e6: [lib/web/native] rename InlineSidebar to InlineEngagement.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

	inline-engagement-text.react.js
	inline-sidebar-text.react.js

4 lines

inline-sidebar-text.react.js

native/

chat/

chat-constants.js

8 lines

composed-message.react.js

40 lines

	inline-engagement.react.js
	inline-sidebar.react.js

54 lines

inline-sidebar.react.js

multimedia-message-tooltip-button.react.js

8 lines

multimedia-message-utils.js

8 lines

robotext-message-tooltip-button.react.js

8 lines

robotext-message.react.js

16 lines

text-message-tooltip-button.react.js

8 lines

utils.js

10 lines

themes/

colors.js

8 lines

web/

chat/

chat-message-list.css

2 lines

composed-message.react.js

18 lines

	inline-engagement.css
	inline-sidebar.css

14 lines

	inline-engagement.react.js
	inline-sidebar.react.js

14 lines

inline-sidebar.css

inline-sidebar.react.js

robotext-message.react.js

10 lines

theme.css

6 lines

utils/

tooltip-utils.js

16 lines

Diff 21024

View Options

lib/hooks/inline-engagement-text.react.js

View Options

lib/hooks/inline-sidebar-text.react.js

View Options

native/chat/chat-constants.js

View Options

native/chat/composed-message.react.js

View Options

native/chat/inline-engagement.react.js

View Options

native/chat/inline-sidebar.react.js

View Options

native/chat/multimedia-message-tooltip-button.react.js

View Options

native/chat/multimedia-message-utils.js

View Options

native/chat/robotext-message-tooltip-button.react.js

View Options

native/chat/robotext-message.react.js

View Options

native/chat/text-message-tooltip-button.react.js

View Options

native/chat/utils.js

View Options

native/themes/colors.js

View Options

web/chat/chat-message-list.css

View Options

web/chat/composed-message.react.js

View Options

web/chat/inline-engagement.css

View Options

web/chat/inline-engagement.react.js

View Options

web/chat/inline-sidebar.css

View Options

web/chat/inline-sidebar.react.js

View Options

web/chat/robotext-message.react.js

View Options

web/theme.css

View Options

web/utils/tooltip-utils.js

[lib/web/native] rename InlineSidebar to InlineEngagementClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21024

lib/hooks/inline-engagement-text.react.js

lib/hooks/inline-sidebar-text.react.js

native/chat/chat-constants.js

native/chat/composed-message.react.js

native/chat/inline-engagement.react.js

native/chat/inline-sidebar.react.js

native/chat/multimedia-message-tooltip-button.react.js

native/chat/multimedia-message-utils.js

native/chat/robotext-message-tooltip-button.react.js

native/chat/robotext-message.react.js

native/chat/text-message-tooltip-button.react.js

native/chat/utils.js

native/themes/colors.js

web/chat/chat-message-list.css

web/chat/composed-message.react.js

web/chat/inline-engagement.css

web/chat/inline-engagement.react.js

web/chat/inline-sidebar.css

web/chat/inline-sidebar.react.js

web/chat/robotext-message.react.js

web/theme.css

web/utils/tooltip-utils.js

[lib/web/native] rename InlineSidebar to InlineEngagement
ClosedPublic
Actions

Revision Contents
Changeset List