[web] Add "Sign in" button to `siweLoginContainer`
ClosedPublic
Actions

Authored by atul on Jan 18 2023, 6:27 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM9da7cea9f704: [web] Add "Sign in" button to `siweLoginContainer`

Summary

Just include "Sign in" button and make sure styling/layout is correct. The button is completely nonfunctional for now.

Test Plan

Here's what it looks like:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jan 18 2023, 6:27 PM

atul published this revision for review.Jan 18 2023, 6:28 PM

atul edited the test plan for this revision. (Show Details)

I still think it's weird to have two buttons "Log in" and "Sign in" at the same time, but that will get addressed in DES-23

This revision is now accepted and ready to land.Jan 18 2023, 6:38 PM

Harbormaster completed remote builds in B15446: Diff 21058.Jan 18 2023, 6:42 PM

rebase before landing

In D6305#188783, @ashoat wrote:

I still think it's weird to have two buttons "Log in" and "Sign in" at the same time, but that will get addressed in DES-23

Agree, but think it's fine for now.

Harbormaster completed remote builds in B15450: Diff 21068.Jan 19 2023, 12:18 AM

Closed by commit rCOMM9da7cea9f704: [web] Add "Sign in" button to `siweLoginContainer` (authored by atul). · Explain WhyJan 19 2023, 10:02 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM9da7cea9f704: [web] Add "Sign in" button to `siweLoginContainer`.

Revision Contents
Changeset List

Path

Size

web/

account/

siwe.css

8 lines

siwe.react.js

3 lines

Diff 21130

View Options

web/account/siwe.css