Page MenuHomePhabricator
Differential D6306

[lib] Move `createSIWEMessage` from `landing` => `lib`
ClosedPublic
Actions

Authored by atul on Jan 18 2023, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 4:25 AM
Unknown Object (File)
Sun, Nov 10, 4:25 AM
Unknown Object (File)
Sun, Nov 10, 4:25 AM
Unknown Object (File)
Sat, Nov 9, 12:00 PM
Unknown Object (File)
Tue, Nov 5, 2:09 AM
Unknown Object (File)
Fri, Nov 1, 4:20 PM
Unknown Object (File)
Fri, Nov 1, 4:20 PM
Unknown Object (File)
Fri, Nov 1, 4:20 PM
View All 67 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM0cfd72cc50b5: [lib] Move `createSIWEMessage` from `landing` => `lib`
Summary

Just a simple drag/drop so it can be reused from web.

Test Plan

Native SIWE flow continues to work as expected:

Simulator Screen Shot - iPhone 14 Pro - 2023-01-18 at 21.56.04.png (2×1 px, 185 KB)

  1. Made a new wallet in Rainbow
  2. Tried native SIWE flow
  3. Was able to log in as expected

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 18 2023, 6:56 PM
atul published this revision for review.Jan 18 2023, 6:57 PM
atul added inline comments.
lib/utils/siwe-utils.js
28–48

intentional

atul edited the test plan for this revision. (Show Details)Jan 18 2023, 6:57 PM
ashoat accepted this revision.Jan 18 2023, 7:00 PM

Please wait on CI before landing

This revision is now accepted and ready to land.Jan 18 2023, 7:00 PM
Harbormaster completed remote builds in B15447: Diff 21059.Jan 18 2023, 7:11 PM
atul updated this revision to Diff 21069.Jan 19 2023, 12:05 AM

rebase before landing

Harbormaster completed remote builds in B15451: Diff 21069.Jan 19 2023, 12:19 AM
Closed by commit rCOMM0cfd72cc50b5: [lib] Move `createSIWEMessage` from `landing` => `lib` (authored by atul). · Explain WhyJan 19 2023, 10:36 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM0cfd72cc50b5: [lib] Move `createSIWEMessage` from `landing` => `lib`.
ashoat added a comment.Jan 20 2023, 7:01 AM
This comment was removed by ashoat.

Revision Contents
Changeset List

PathSize
landing/
1 line
20 lines
lib/
1 line
utils/
23 lines

Diff 21059

View Options

landing/package.json

Loading...
View Options

landing/siwe.react.js

Loading...
View Options

lib/package.json

Loading...
View Options

lib/utils/siwe-utils.js

Loading...