Page MenuHomePhabricator
Differential D6317

[lib] remove the word reply/replies from InlineEngagement
ClosedPublic
Actions

Authored by ginsu on Jan 19 2023, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 23, 2:14 PM
Unknown Object (File)
Sun, Sep 15, 12:40 PM
Unknown Object (File)
Tue, Sep 10, 11:08 AM
Unknown Object (File)
Tue, Sep 10, 11:08 AM
Unknown Object (File)
Tue, Sep 10, 11:08 AM
Unknown Object (File)
Tue, Sep 10, 11:08 AM
Unknown Object (File)
Tue, Sep 10, 11:04 AM
Unknown Object (File)
Aug 28 2024, 10:02 AM
View All 100 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
ashoat
Commits
rCOMM2adf8782038a: [lib] remove the word reply/replies from InlineEngagement
Summary

Removed the word reply/replies from InlineEngagement to reflect the new design

Screenshot 2023-01-19 at 5.50.52 PM.png (1×1 px, 139 KB)

Linear Task: ENG-2720

Test Plan

Please see the screenshots to see the before and after of my changes

Before:

Screenshot 2023-01-19 at 11.56.10 PM.png (1×3 px, 1 MB)

After:

Screenshot 2023-01-19 at 11.56.29 PM.png (1×3 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 19 2023, 9:11 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 19 2023, 9:11 PM
ginsu edited the summary of this revision. (Show Details)Jan 19 2023, 9:17 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, tomek.
ginsu attached a referenced file: F335487: Screenshot 2023-01-19 at 11.56.29 PM.png. (Show Details)
ginsu attached a referenced file: F335486: Screenshot 2023-01-19 at 11.56.10 PM.png. (Show Details)
ginsu attached a referenced file: F335485: Screenshot 2023-01-19 at 5.50.52 PM.png. (Show Details)
Harbormaster completed remote builds in B15488: Diff 21128.Jan 19 2023, 9:26 PM
ginsu requested review of this revision.Jan 19 2023, 9:26 PM
ginsu added a child revision: D6318: [web] implement new InlineEngagement design.Jan 19 2023, 9:32 PM
ashoat accepted this revision.Jan 20 2023, 6:56 AM
ashoat added inline comments.
lib/hooks/inline-engagement-text.react.js
10 ↗(On Diff #21128)

No need for a template literal. Just cast as a string

This revision is now accepted and ready to land.Jan 20 2023, 6:56 AM
ginsu updated this revision to Diff 21150.Jan 20 2023, 9:56 AM

address ashoat's comments

Harbormaster completed remote builds in B15505: Diff 21150.Jan 20 2023, 10:11 AM
Closed by commit rCOMM2adf8782038a: [lib] remove the word reply/replies from InlineEngagement (authored by ginsu). · Explain WhyJan 20 2023, 11:18 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM2adf8782038a: [lib] remove the word reply/replies from InlineEngagement.

Revision Contents
Changeset List

PathSize
lib/
hooks/
2 lines

Diff 21152

View Options

lib/hooks/inline-engagement-text.react.js

Loading...