Page MenuHomePhabricator
Differential D6319

[native] Add URI scheme to debug Info.plist
ClosedPublic
Actions

Authored by bartek on Jan 20 2023, 3:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 3:20 AM
Unknown Object (File)
Sun, Apr 28, 3:19 AM
Unknown Object (File)
Sun, Apr 28, 3:19 AM
Unknown Object (File)
Sun, Apr 28, 3:01 AM
Unknown Object (File)
Mar 29 2024, 8:00 PM
Unknown Object (File)
Mar 28 2024, 2:47 PM
Unknown Object (File)
Mar 28 2024, 2:47 PM
Unknown Object (File)
Mar 28 2024, 2:46 PM
View All 30 Files
Subscribers
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMc78260547876: [native] Add URI scheme to debug Info.plist
Summary

Resolves ENG-2730

Added the comm:// URI cheme to Info.debug.plist.
Didn't patch Expo, the --scheme flag is sufficient for now.

Test Plan
  • For physical device:
    1. Build app (in Xcode or yarn expo run:ios -d --no-bundler - see D6309)
cd native
yarn dev --scheme comm

Note that the URL has changed to a deep link! see image below

  1. Scan the QR code with the camera app. The Comm app should launch automatically, without the Expo launcher screen
  • For simulator:
    1. Build app - same as above, just select simulator
    2. Same as above
    3. In the Metro console, press the i key on the keyboard (or shift+i for device select screen). The Comm app should launch automatically, without the Expo launcher screen

Screenshot 2023-01-20 at 10.50.59.png (366×633 px, 21 KB)

It is also possible to check if Expo's scheme utility uri-scheme detects the scheme correctly:

$ npx uri-scheme list --info-path ./ios/Comm/Info.debug.plist
› iOS: Schemes for config: ./ios/Comm/Info.debug.plist
› comm://

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jan 20 2023, 3:35 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptJan 20 2023, 3:35 AM
bartek edited the test plan for this revision. (Show Details)Jan 20 2023, 3:46 AM
bartek attached a referenced file: F336765: Screenshot 2023-01-20 at 10.50.59.png. (Show Details)
Harbormaster completed remote builds in B15493: Diff 21136.Jan 20 2023, 3:48 AM
bartek edited the test plan for this revision. (Show Details)Jan 20 2023, 3:52 AM
bartek edited the test plan for this revision. (Show Details)Jan 20 2023, 3:55 AM
bartek attached a referenced file: F336775: rpreplay-final1674208318_Qi2cd8u6.mp4. (Show Details)Jan 20 2023, 3:59 AM
bartek published this revision for review.Jan 20 2023, 4:03 AM
ashoat accepted this revision.Jan 20 2023, 10:36 AM

Same question about "opting in" as in D6320 – feels like we should make this the default in yarn start

bartek mentioned this in D6320: [native] Add URI scheme to debug AndroidManifest.xml.Jan 20 2023, 2:16 PM
In D6319#189435, @ashoat wrote:

Same question about "opting in" as in D6320 – feels like we should make this the default in yarn start

Answered in https://phab.comm.dev/D6320#189520

atul accepted this revision.Jan 20 2023, 5:16 PM
This revision is now accepted and ready to land.Jan 20 2023, 5:16 PM
bartek added a child revision: D6328: [native] Patch @expo/cli to support debug-only scheme.Jan 21 2023, 9:30 AM
bartek edited the test plan for this revision. (Show Details)Jan 21 2023, 9:47 AM
Closed by commit rCOMMc78260547876: [native] Add URI scheme to debug Info.plist (authored by bartek). · Explain WhyJan 23 2023, 7:18 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMc78260547876: [native] Add URI scheme to debug Info.plist.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm/
9 lines

Diff 21192

View Options

native/ios/Comm/Info.debug.plist

Loading...