Page MenuHomePhabricator
Differential D6326

[web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint
ClosedPublic
Actions

Authored by atul on Jan 20 2023, 11:53 AM.
Tags
None
Referenced Files
F3351621: D6326.diff
Sat, Nov 23, 2:51 AM
Unknown Object (File)
Tue, Nov 12, 12:24 AM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:25 AM
Unknown Object (File)
Sat, Nov 9, 2:25 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMb1d7f8c22a38: [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint
rCOMM1b8947b6dbb1: [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint
Summary

We prompt user to sign SIWEMessage with their wallet when "Sign in" is clicked. Once the message is signed, the user will be logged into the web app.

Test Plan

MetaMask:

5d3d74.png (2×1 px, 387 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 20 2023, 11:53 AM
atul updated this revision to Diff 21156.Jan 20 2023, 12:00 PM

fix

atul edited the test plan for this revision. (Show Details)Jan 20 2023, 12:01 PM
Harbormaster failed remote builds in B15508: Diff 21155!Jan 20 2023, 12:01 PM
Harbormaster completed remote builds in B15509: Diff 21156.Jan 20 2023, 12:15 PM
atul requested review of this revision.Jan 20 2023, 12:15 PM
atul planned changes to this revision.Jan 20 2023, 12:20 PM
atul updated this revision to Diff 21166.Jan 21 2023, 3:17 PM

update

atul retitled this revision from [web] Prompt user to sign SIWEMessage with wallet when "Sign in" clicked to [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint.Jan 21 2023, 3:17 PM
atul edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B15517: Diff 21166.Jan 21 2023, 3:31 PM
ashoat accepted this revision.Jan 21 2023, 3:34 PM
ashoat added inline comments.
web/account/siwe.react.js
108–114 ↗(On Diff #21166)

I think omitting the extra await keyword here is better for performance because it avoids an interupt. Also this looks cleaner

119 ↗(On Diff #21166)

This doesn't need to be an async function

This revision is now accepted and ready to land.Jan 21 2023, 3:34 PM
atul updated this revision to Diff 21174.Jan 22 2023, 2:52 PM

rebase before addressing feedback

Harbormaster completed remote builds in B15525: Diff 21174.Jan 22 2023, 3:07 PM
atul updated this revision to Diff 21175.Jan 22 2023, 3:54 PM

address feedback

Harbormaster completed remote builds in B15526: Diff 21175.Jan 22 2023, 4:08 PM
ashoat added inline comments.Jan 22 2023, 4:19 PM
web/account/siwe.react.js
108 ↗(On Diff #21175)

The async should not be there... you're returning a Promise<Promise<something>> now

If you ever have an async function without an await keyword inside, that's generally (not always) a red flag

Closed by commit rCOMM1b8947b6dbb1: [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint (authored by atul). · Explain WhyJan 22 2023, 5:12 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM1b8947b6dbb1: [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint.
atul added a reverting change: rCOMM3e2dd4112ac3: Revert "[web] Have user sign SIWEMessage with wallet and hit `siwe_auth`….
atul reopened this revision.Jan 22 2023, 5:14 PM
This revision is now accepted and ready to land.Jan 22 2023, 5:14 PM
atul updated this revision to Diff 21179.Jan 22 2023, 5:15 PM

address inline comment

This revision was landed with ongoing or failed builds.Jan 22 2023, 5:16 PM
Closed by commit rCOMMb1d7f8c22a38: [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb1d7f8c22a38: [web] Have user sign SIWEMessage with wallet and hit `siwe_auth` endpoint.
Harbormaster completed remote builds in B15527: Diff 21179.Jan 22 2023, 5:30 PM

Revision Contents
Changeset List

PathSize
web/
account/
21 lines

Diff 21156

View Options

web/account/siwe.react.js

Loading...