Page MenuHomePhabricator
Differential D6351

[native] implement new InlineEngagement design
ClosedPublic
Actions

Authored by ginsu on Jan 23 2023, 10:21 AM.
Tags
None
Referenced Files
F2836256: D6351.diff
Sat, Sep 28, 3:46 PM
Unknown Object (File)
Tue, Sep 10, 3:59 PM
Unknown Object (File)
Tue, Sep 10, 11:08 AM
Unknown Object (File)
Tue, Sep 10, 11:08 AM
Unknown Object (File)
Tue, Sep 10, 11:08 AM
Unknown Object (File)
Tue, Sep 10, 11:08 AM
Unknown Object (File)
Tue, Sep 10, 11:08 AM
Unknown Object (File)
Tue, Sep 10, 11:04 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
Commits
rCOMMb0c1ad95d9ca: [native] implement new InlineEngagement design
Summary

implemented the new InlineEngagement design. The new design splits the InlineEngagement into two separate parts

Depends on D6350
Linear Task: ENG-2720

Test Plan

Please watch the demo video to see the new InlineEngagement

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 23 2023, 10:21 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 23 2023, 10:21 AM
ginsu edited the summary of this revision. (Show Details)Jan 23 2023, 10:25 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, tomek.
ginsu added a parent revision: D6350: [native] introduce MessageReactionsModal.
ginsu attached a referenced file: F340172: Screen Recording 2023-01-23 at 1.24.06 PM.mov. (Show Details)
Harbormaster completed remote builds in B15552: Diff 21213.Jan 23 2023, 10:35 AM
ginsu requested review of this revision.Jan 23 2023, 10:35 AM
ginsu updated this revision to Diff 21245.Jan 24 2023, 8:40 AM

address ashoat's comments

Harbormaster completed remote builds in B15580: Diff 21245.Jan 24 2023, 8:54 AM
atul accepted this revision.Jan 24 2023, 11:05 AM
atul added inline comments.
native/chat/inline-engagement.react.js
55 ↗(On Diff #21245)

Do we really need to introduce a new noThreadInfo variable for this?

57 ↗(On Diff #21245)

Can we just do !threadInfo here?

This revision is now accepted and ready to land.Jan 24 2023, 11:05 AM
ginsu updated this revision to Diff 21268.Jan 24 2023, 1:03 PM

address atul's comments

Harbormaster completed remote builds in B15602: Diff 21268.Jan 24 2023, 1:17 PM
Closed by commit rCOMMb0c1ad95d9ca: [native] implement new InlineEngagement design (authored by ginsu). · Explain WhyJan 24 2023, 1:18 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb0c1ad95d9ca: [native] implement new InlineEngagement design.

Revision Contents
Changeset List

PathSize
native/
chat/
114 lines
navigation/
7 lines

Diff 21213

View Options

native/chat/inline-engagement.react.js

Loading...
View Options

native/navigation/root-navigator.react.js

Loading...