Paths

Table of Contentst

Differential D6425

[native][web] Show ENS name for message author
ClosedPublic
Actions

Authored by ashoat on Jan 28 2023, 12:22 PM.

Tags

None

Referenced Files

	F348673: Screenshot 2023-01-28 at 7.21.25 AM.png
	Jan 28 2023, 12:23 PM

	F348672: Screenshot 2023-01-28 at 7.21.33 AM.png
	Jan 28 2023, 12:23 PM

Subscribers

Details

Reviewers

Commits

rCOMM85afa94f1918: [native][web] Show ENS name for message author

Test Plan

`web`	`native`

Diff Detail

Repository

Branch

ashoat/ens

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 28 2023, 12:22 PM

Herald added a subscriber: tomek. · View Herald TranscriptJan 28 2023, 12:22 PM

ashoat added inline comments.Jan 28 2023, 12:23 PM

native/chat/message-header.react.js
31	Note that `useStringForUser` will only return falsey if passed falsey
web/chat/composed-message.react.js
95	Note that `useStringForUser` will only return falsey if passed falsey

ashoat edited the test plan for this revision. (Show Details)Jan 28 2023, 12:23 PM

Harbormaster completed remote builds in B15759: Diff 21491.Jan 28 2023, 12:36 PM

ashoat requested review of this revision.Jan 28 2023, 12:36 PM

atul accepted this revision.Jan 28 2023, 8:41 PM

atul added inline comments.

native/chat/message-header.react.js
6	Been seeing this through the stack so it makes sense to me, but I wonder if a more descriptive name might be helpful for others in the future. Maybe `useStringIdentifierForUser` or something? idk

This revision is now accepted and ready to land.Jan 28 2023, 8:41 PM

ashoat added inline comments.Jan 28 2023, 9:14 PM

native/chat/message-header.react.js
6	That seems a bit wordy... open to rewording but not sure of the new name and need to push out a lot of code this weekend

Closed by commit rCOMM85afa94f1918: [native][web] Show ENS name for message author. · Explain WhyJan 28 2023, 9:20 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM85afa94f1918: [native][web] Show ENS name for message author.

Revision Contents
Changeset List

Path

Size

native/

chat/

message-header.react.js

11 lines

web/

chat/

composed-message.react.js

17 lines

Diff 21491

native/chat/message-header.react.js

Loading...

web/chat/composed-message.react.js

Loading...