Paths

Table of Contentst

Differential D6425

[native][web] Show ENS name for message author
ClosedPublic
Actions

Authored by ashoat on Jan 28 2023, 4:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 30, 3:48 AM

	Unknown Object (File)
	Mon, Sep 30, 3:34 AM

	Unknown Object (File)
	Tue, Sep 24, 2:11 AM

	Unknown Object (File)
	Fri, Sep 20, 11:30 PM

	Unknown Object (File)
	Thu, Sep 19, 3:17 AM

	Unknown Object (File)
	Thu, Sep 19, 2:35 AM

	Unknown Object (File)
	Wed, Sep 18, 8:54 PM

	Unknown Object (File)
	Wed, Sep 18, 7:57 PM

View All 40 Files

Subscribers

Details

Reviewers

Commits

rCOMM85afa94f1918: [native][web] Show ENS name for message author

Test Plan

`web`	`native`

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 28 2023, 4:22 AM

Herald added a subscriber: tomek. · View Herald TranscriptJan 28 2023, 4:22 AM

ashoat added inline comments.Jan 28 2023, 4:23 AM

native/chat/message-header.react.js
31 ↗	(On Diff #21491)	Note that `useStringForUser` will only return falsey if passed falsey
web/chat/composed-message.react.js
95 ↗	(On Diff #21491)	Note that `useStringForUser` will only return falsey if passed falsey

ashoat edited the test plan for this revision. (Show Details)Jan 28 2023, 4:23 AM

Harbormaster completed remote builds in B15759: Diff 21491.Jan 28 2023, 4:36 AM

ashoat requested review of this revision.Jan 28 2023, 4:36 AM

atul accepted this revision.Jan 28 2023, 12:41 PM

atul added inline comments.

native/chat/message-header.react.js
6 ↗	(On Diff #21491)	Been seeing this through the stack so it makes sense to me, but I wonder if a more descriptive name might be helpful for others in the future. Maybe `useStringIdentifierForUser` or something? idk

This revision is now accepted and ready to land.Jan 28 2023, 12:41 PM

ashoat added inline comments.Jan 28 2023, 1:14 PM

native/chat/message-header.react.js
6 ↗	(On Diff #21491)	That seems a bit wordy... open to rewording but not sure of the new name and need to push out a lot of code this weekend

Closed by commit rCOMM85afa94f1918: [native][web] Show ENS name for message author (authored by ashoat). · Explain WhyJan 28 2023, 1:20 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM85afa94f1918: [native][web] Show ENS name for message author.

Revision Contents
Changeset List

Path

Size

native/

chat/

message-header.react.js

11 lines

web/

chat/

composed-message.react.js

17 lines

Diff 21506

native/chat/message-header.react.js

Loading...

web/chat/composed-message.react.js

Loading...