Paths

Table of Contentst

[lib] Factor out normalization functions in ENSCache
ClosedPublic
Actions

Authored by ashoat on Jan 28 2023, 6:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 1, 1:55 PM

	Unknown Object (File)
	Tue, Oct 29, 7:54 PM

	Unknown Object (File)
	Tue, Oct 29, 7:54 PM

	Unknown Object (File)
	Tue, Oct 29, 7:54 PM

	Unknown Object (File)
	Tue, Oct 29, 7:51 PM

	Unknown Object (File)
	Oct 1 2024, 12:22 PM

	Unknown Object (File)
	Oct 1 2024, 12:22 PM

	Unknown Object (File)
	Oct 1 2024, 10:30 AM

View All 47 Files

Subscribers

tomek

Details

Reviewers

atul

Commits

rCOMM6cecac813123: [lib] Factor out normalization functions in ENSCache

Summary

They're already used three times each, and I'm about to introduce new usages. I think it's better for this logic to be in one place.

Test Plan

cd lib && ALCHEMY_API_KEY=... yarn test utils/ens-cache.test.js

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 28 2023, 6:46 AM

Herald added a subscriber: tomek. · View Herald TranscriptJan 28 2023, 6:46 AM

Harbormaster completed remote builds in B15762: Diff 21494.Jan 28 2023, 6:57 AM

ashoat requested review of this revision.Jan 28 2023, 6:57 AM

ashoat added a child revision: D6427: [lib] Factor out constants in ENSCache tests.Jan 28 2023, 7:01 AM

atul accepted this revision.Jan 28 2023, 12:42 PM

This revision is now accepted and ready to land.Jan 28 2023, 12:42 PM

Closed by commit rCOMM6cecac813123: [lib] Factor out normalization functions in ENSCache (authored by ashoat). · Explain WhyJan 28 2023, 1:20 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6cecac813123: [lib] Factor out normalization functions in ENSCache.

Revision Contents
Changeset List

Path

Size

lib/

utils/

ens-cache.js

27 lines

Diff 21507

View Options

[lib] Factor out normalization functions in ENSCacheClosedPublicActions