[lib] Don't fetch the same ENS names simultaneously
ClosedPublic
Actions

Authored by ashoat on Jan 28 2023, 8:05 AM.

Details

Reviewers

atul

Commits

rCOMM6b8c198fcd12: [lib] Don't fetch the same ENS names simultaneously

Summary

Sometimes when some interfaces load, there will be multiple places where the same ENS name needs to be fetched. Currently, that results in multiple queries for the same ENS name.

This diff makes sure we don't query for the same ENS name simultaneously.

Depends on D6430

Test Plan

cd lib && ALCHEMY_API_KEY=... yarn test utils/ens-cache.test.js

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 28 2023, 8:05 AM

Herald added a subscriber: tomek. · View Herald TranscriptJan 28 2023, 8:05 AM

Harbormaster completed remote builds in B15767: Diff 21499.Jan 28 2023, 8:19 AM

ashoat requested review of this revision.Jan 28 2023, 8:19 AM

atul accepted this revision.Jan 28 2023, 1:01 PM

This revision is now accepted and ready to land.Jan 28 2023, 1:01 PM

Closed by commit rCOMM6b8c198fcd12: [lib] Don't fetch the same ENS names simultaneously (authored by ashoat). · Explain WhyJan 28 2023, 1:20 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6b8c198fcd12: [lib] Don't fetch the same ENS names simultaneously.

Revision Contents
Changeset List

Path

Size

lib/

utils/

ens-cache.js

47 lines

ens-cache.test.js

54 lines

Diff 21512

View Options

lib/utils/ens-cache.js