[native] introduce canCreateReactionFromMessage prop to Tooltip component
AbandonedPublic
Actions

Authored by ginsu on Jan 29 2023, 3:00 PM.

Details

Reviewers

tomek
atul

Summary

introduce canCreateReactionFromMessage prop to Tooltip component. This will be used to conditonally render the reaction selection popover

Depends on D6447
Linear Task: ENG-2779

Test Plan

flow and this will be further tested in a subseqent diff

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 29 2023, 3:00 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 29 2023, 3:00 PM

ginsu added reviewers: tomek, atul.Jan 29 2023, 3:01 PM

ginsu edited the summary of this revision. (Show Details)Jan 29 2023, 3:09 PM

ginsu added a parent revision: D6447: [native] change location to tooltipLocation in the TooltipParams.

Harbormaster completed remote builds in B15791: Diff 21537.Jan 29 2023, 3:11 PM

ginsu requested review of this revision.Jan 29 2023, 3:11 PM

ginsu added a child revision: D6452: [native] introduce get reactionSelectionPopoverLocation.Jan 29 2023, 8:24 PM

tomek requested changes to this revision.Jan 30 2023, 4:48 AM

tomek added inline comments.

native/navigation/tooltip.react.js
752–759	Can we limit invariant usage only to the cases where it is necessary?

This revision now requires changes to proceed.Jan 30 2023, 4:48 AM

This diff is no longer relevant since we don't want canCreateReactionFromMessage in the tooltip component

Revision Contents
Changeset List

Path

Size

native/

navigation/

tooltip.react.js

13 lines

Diff 21537

View Options

native/navigation/tooltip.react.js

[native] introduce canCreateReactionFromMessage prop to Tooltip componentAbandonedPublicActions