Paths

Table of Contentst

Differential D6528

[lib][native][web] Fetch ENS names for robotext messages
ClosedPublic
Actions

Authored by ashoat on Feb 2 2023, 8:43 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 11, 8:27 AM

	Unknown Object (File)
	Tue, Jun 11, 8:27 AM

	Unknown Object (File)
	Tue, Jun 11, 8:27 AM

	Unknown Object (File)
	Tue, Jun 11, 8:27 AM

	Unknown Object (File)
	Fri, Jun 7, 9:08 PM

	Unknown Object (File)
	Fri, Jun 7, 9:08 PM

	Unknown Object (File)
	Fri, Jun 7, 9:07 PM

	Unknown Object (File)
	Fri, Jun 7, 9:07 PM

View All 58 Files

Subscribers

Details

Reviewers

Commits

rCOMM6f9d494a4ad0: [lib][native][web] Fetch ENS names for robotext messages

Summary

Woohoo!!

Depends on D6527

Test Plan

`web`	`native`

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 2 2023, 8:43 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 2 2023, 8:43 AM

ashoat added a child revision: D6529: [lib] Use term "channel" in threadNoun.Feb 2 2023, 8:45 AM

ashoat edited the test plan for this revision. (Show Details)Feb 2 2023, 8:48 AM

ashoat added inline comments.

lib/utils/entity-text.js
334 ↗	(On Diff #21860)	Converting this to an object and back to a string is necessary for Flow, which otherwise complains that `useENSNames` can only take an object. (Technically a string is an object, so this works in JS, but Flow doesn't allow it)

Harbormaster completed remote builds in B16015: Diff 21860.Feb 2 2023, 8:59 AM

ashoat requested review of this revision.Feb 2 2023, 8:59 AM

Nice

This revision is now accepted and ready to land.Feb 2 2023, 11:07 AM

Closed by commit rCOMM6f9d494a4ad0: [lib][native][web] Fetch ENS names for robotext messages (authored by ashoat). · Explain WhyFeb 2 2023, 11:41 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6f9d494a4ad0: [lib][native][web] Fetch ENS names for robotext messages.

Revision Contents
Changeset List

Path

Size

lib/

utils/

27 lines

native/

chat/

inner-robotext-message.react.js

6 lines

web/

chat/

robotext-message.react.js

10 lines

Diff 21893

lib/utils/entity-text.js

Loading...

native/chat/inner-robotext-message.react.js

Loading...

web/chat/robotext-message.react.js

Loading...