[lib] Introduce basePluralize
ClosedPublic
Actions

Authored by ashoat on Feb 1 2023, 10:07 PM.

Details

Reviewers

atul

Commits

rCOMMa95f14bef093: [lib] Introduce basePluralize

Summary

In the next diff, I introduce a function that pluralizes EntityText. This diff factors out the shared functionality.

Depends on D6510

Test Plan

The test cases in lib/utils/text-utils.test.js are extremely thorough

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 1 2023, 10:07 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 1 2023, 10:07 PM

ashoat added a child revision: D6512: [lib] Convert AddMembers/RemoveMembers robotext to use EntityText.Feb 1 2023, 10:07 PM

Harbormaster completed remote builds in B15970: Diff 21806.Feb 1 2023, 10:23 PM

ashoat requested review of this revision.Feb 1 2023, 10:23 PM

baseCase isn't necessary, as it can be constructed by calling composeFunc('')

Harbormaster completed remote builds in B16002: Diff 21846.Feb 2 2023, 2:51 PM

The test cases in lib/utils/text-utils.test.js are extremely thorough

Nice, glad these ended up being useful

This revision is now accepted and ready to land.Feb 2 2023, 6:45 PM

Closed by commit rCOMMa95f14bef093: [lib] Introduce basePluralize. · Explain WhyFeb 2 2023, 7:41 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa95f14bef093: [lib] Introduce basePluralize.

Revision Contents
Changeset List

Path

Size

lib/

utils/

text-utils.js

48 lines

Diff 21880

View Options

[lib] Introduce basePluralizeClosedPublicActions