Page MenuHomePhabricator
Differential D6552

[lib] Add timeout to ENSCache
ClosedPublic
Actions

Authored by ashoat on Feb 3 2023, 12:33 AM.
Tags
None
Referenced Files
F3493283: D6552.diff
Thu, Dec 19, 2:45 AM
Unknown Object (File)
Fri, Nov 22, 2:18 AM
Unknown Object (File)
Fri, Nov 22, 2:18 AM
Unknown Object (File)
Fri, Nov 22, 2:18 AM
Unknown Object (File)
Fri, Nov 22, 2:17 AM
Unknown Object (File)
Oct 22 2024, 3:19 AM
Unknown Object (File)
Oct 22 2024, 3:19 AM
Unknown Object (File)
Oct 22 2024, 3:03 AM
View All 56 Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM3f6d762948d8: [lib] Add timeout to ENSCache
Summary

I noticed that when the Alchemy key is missing, ethers.js won't resolve any promises.

Introducing this timeout makes sure that async functions won't stall indefinitely, and can fall back to using the ETH address if the ENS name fails to resolve.

Depends on D6551

Test Plan

Confirmed timeout works and that async functions resolve within 5s

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Feb 3 2023, 12:33 AM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 3 2023, 12:33 AM
Harbormaster completed remote builds in B16059: Diff 21933.Feb 3 2023, 12:48 AM
ashoat requested review of this revision.Feb 3 2023, 12:48 AM
atul accepted this revision.Feb 4 2023, 11:12 AM
atul added inline comments.
lib/utils/ens-cache.js
84–87

Interesting

This revision is now accepted and ready to land.Feb 4 2023, 11:12 AM
Closed by commit rCOMM3f6d762948d8: [lib] Add timeout to ENSCache (authored by ashoat). · Explain WhyFeb 5 2023, 7:53 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM3f6d762948d8: [lib] Add timeout to ENSCache.

Revision Contents
Changeset List

PathSize
lib/
utils/
22 lines

Diff 21933

View Options

lib/utils/ens-cache.js

Loading...