Page MenuHomePhabricator
Differential D6591

[lib] Introduce entity-helpers.js to help resolve ThreadInfo into ResolvedThreadInfo
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 6:23 PM.
Tags
None
Referenced Files
F3498873: D6591.diff
Thu, Dec 19, 9:45 PM
Unknown Object (File)
Wed, Dec 11, 2:56 PM
Unknown Object (File)
Nov 18 2024, 7:37 PM
Unknown Object (File)
Nov 14 2024, 8:20 PM
Unknown Object (File)
Nov 14 2024, 8:20 PM
Unknown Object (File)
Nov 8 2024, 8:04 AM
Unknown Object (File)
Oct 26 2024, 9:01 PM
Unknown Object (File)
Oct 26 2024, 9:01 PM
View All 79 Files
Subscribers
tomek

Details

Reviewers
atul
inka
Commits
rCOMM117eef980510: [lib] Introduce entity-helpers.js to help resolve ThreadInfo into…
Summary

In a following diff, I'll update ThreadInfo.uiName to be string | $ReadOnlyArray<UserEntity>. At that point, this new ResolvedThreadInfo type will be differentiated from ThreadInfo. But at this this point, it is a straight copy-paste.

This diff introduces helpful utilities for resolving ThreadInfo into ResolvedThreadInfo, and a first use case, which is in calendar-selectors.js.

This diff has to come before I change the types, otherwise Flow would report errors.

Depends on D6590

Test Plan

Here is FilterPanel, which is now able to resolve ENS names:

Screenshot 2023-02-04 at 9.46.35 PM.png (594×622 px, 35 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
selectors/
4 lines
types/
4 lines
18 lines
utils/
73 lines

Diff 22004

View Options

lib/selectors/calendar-selectors.js

Loading...
View Options

lib/types/filter-types.js

Loading...
View Options

lib/types/thread-types.js

Loading...
View Options

lib/utils/entity-helpers.js

Loading...