[lib] Show "just you" for thread title if there are no members besides you
ClosedPublic
Actions

Authored by ashoat on Feb 6 2023, 5:30 AM.

Details

Reviewers

inka
tomek
atul

Commits

rCOMM181fa7607ab6: [lib] Show "just you" for thread title if there are no members besides you

Summary

This resolves ENG-2933, which was broken in D6615 when I removed the 'just you' special-case there.

Since filtering out the user (and pluralization) are now handled in getNameForThreadEntity, we need to check the length of the list there instead of in threadUIName now.

Test Plan

Make sure there are no empty strings in the web calendar filters, and that 'just you' appears where the empty strings previously did

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/fix_notifs

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 6 2023, 5:30 AM

Harbormaster completed remote builds in B16175: Diff 22125.Feb 6 2023, 5:49 AM

ashoat requested review of this revision.Feb 6 2023, 5:49 AM

tomek accepted this revision.Feb 6 2023, 8:59 AM

This revision is now accepted and ready to land.Feb 6 2023, 8:59 AM

Closed by commit rCOMM181fa7607ab6: [lib] Show "just you" for thread title if there are no members besides you (authored by ashoat). · Explain WhyFeb 6 2023, 9:16 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM181fa7607ab6: [lib] Show "just you" for thread title if there are no members besides you.

Revision Contents
Changeset List

Path

Size

lib/

utils/

entity-text.js

3 lines

Diff 22125

View Options

[lib] Show "just you" for thread title if there are no members besides youClosedPublicActions