[landing] Restyle `SIWE` to match `web`
ClosedPublic
Actions

Authored by atul on Feb 7 2023, 2:02 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMf71131a39819: [landing] Restyle `SIWE` to match `web`

Summary

Various styling tweaks so native more closely matches web.

Depends on D6652

Test Plan

Here's how it looks on iPhone 14 Pro Max:

Simulator Screen Shot - iPhone 14 Pro Max - 2023-02-07 at 17.00.45.png (2×1 px, 1 MB)

Here's how it looks on iPhone SE:

Simulator Screen Shot - iPhone SE (3rd generation) - 2023-02-07 at 17.00.14.png (1×750 px, 379 KB)

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 7 2023, 2:02 PM

atul published this revision for review.Feb 7 2023, 2:03 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B16261: Diff 22238.Feb 7 2023, 2:17 PM

Can we update the BottomSheet color to match the background color here? Not into the discontinuity there

Given that this will break existing clients either way, I wonder if we should just reconsider the background color entirely and just keep the old one...

This revision now requires changes to proceed.Feb 8 2023, 5:07 AM

atul abandoned this revision.Feb 8 2023, 8:52 AM

atul reclaimed this revision.Feb 17 2023, 12:09 AM

This revision now requires changes to proceed.Feb 17 2023, 12:09 AM

In D6655#198310, @ashoat wrote:

Can we update the BottomSheet color to match the background color here? Not into the discontinuity there

Given that this will break existing clients either way, I wonder if we should just reconsider the background color entirely and just keep the old one...

Can either have BottomSheet "handle" color match the RainbowKit background or the background color from the designs.

Will opt to just keep the previous background color to keep things simple.

address feedback