[native] Fixed crash when logging out while thread opened
ClosedPublic
Actions

Authored by • kuba on Feb 8 2023, 6:07 AM.

Details

Reviewers

tomek

Commits

Summary

Removed invariant, which was causing the error, and modified measureMessages method so that it can handle the case where messages is null.

Test Plan

Checked logging out while there was opened the chat window, now it doesn't throw an error.

Repository

rCOMM Comm

Branch

kuba/logout-crash

Lint

No Lint Coverage

Unit

No Test Coverage

• kuba requested review of this revision.Feb 8 2023, 6:23 AM

The summary can be improved a bit

checked null values in measureMessages method.

This can be replaced by more correct description, e.g.

modified measureMessages method so that it can handle the case where messages is null

native/chat/message-list-container.react.js
93–117	It seems like it should be possible to just avoid calling `measureMessages` when `messageListData` is null. We even have some code to handle `!newListData && oldListData` case. On the other hand, `measureMessages` already supports null `threadInfo`, so doing the same for `messages` also makes sense. So it seems like the current approach is ok.