Page MenuHomePhabricator

Add .js suffix to all file imports
ClosedPublic

Authored by ashoat on Feb 11 2023, 12:00 PM.
Tags
None
Referenced Files
F3246684: D6692.id22339.largetrue.diff
Fri, Nov 15, 1:26 AM
F3246444: D6692.id22339.diff
Thu, Nov 14, 11:48 PM
Unknown Object (File)
Sun, Oct 27, 5:51 PM
Unknown Object (File)
Oct 14 2024, 2:01 PM
Unknown Object (File)
Sep 28 2024, 10:16 PM
Unknown Object (File)
Sep 28 2024, 10:16 PM
Unknown Object (File)
Sep 28 2024, 10:16 PM
Unknown Object (File)
Sep 28 2024, 10:16 PM
Subscribers
None

Details

Summary

Full context in ENG-2982, but basically Node 19 and Webpack 5 want you to explicitly specify the suffix.

To make this diff I ran a codemod script, which I'm not committing, but is documented in the task.

Test Plan

The way I ran the codemod script is documented in the task. I also tested this diff and the rest of the stack by running web, landing, keyserver, and native all together and making sure it still worked

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2023, 12:13 PM
Harbormaster failed remote builds in B16333: Diff 22335!

I ran yarn eslint:fix to fix ESLint warnings that the CI caught

Checked a couple files, but effectively blindly accepting and trusting the codemod

This revision is now accepted and ready to land.Feb 12 2023, 3:45 PM
This revision was automatically updated to reflect the committed changes.