Page MenuHomePhabricator
Differential D6693

Update eslint-plugin-import to 2.27.5
ClosedPublic
Actions

Authored by ashoat on Feb 11 2023, 12:00 PM.
Tags
None
Referenced Files
F3503671: D6693.id22368.diff
Fri, Dec 20, 6:07 AM
Unknown Object (File)
Tue, Dec 17, 1:10 AM
Unknown Object (File)
Mon, Dec 16, 12:52 AM
Unknown Object (File)
Mon, Dec 16, 12:50 AM
Unknown Object (File)
Sat, Dec 14, 11:48 PM
Unknown Object (File)
Tue, Dec 10, 7:48 PM
Unknown Object (File)
Sun, Dec 8, 9:34 AM
Unknown Object (File)
Sun, Nov 24, 8:24 PM
View All Files
Subscribers
atul
tomek

Details

Reviewers
atul
Commits
rCOMMa9cb552e207c: Update eslint-plugin-import to 2.27.5
Summary

I updated this because I thought I was using it right but it wasn't working. Turns out I was using it wrong, but figured it doesn't hurt to upgrade anyways.

Depends on D6692

Test Plan
  1. No breaking changes in the CHANGELOG.md file
  2. Ran yarn eslint:fix in the root of the repo and confirmed no changes occurred

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Feb 11 2023, 12:00 PM
Herald added subscribers: atul, tomek. · View Herald TranscriptFeb 11 2023, 12:00 PM
ashoat added a reviewer: atul.Feb 11 2023, 12:01 PM
ashoat added a child revision: D6694: Add ESLint rule to enforce extensions for imports.Feb 11 2023, 12:05 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2023, 12:14 PM
Harbormaster failed remote builds in B16334: Diff 22336!
ashoat updated this revision to Diff 22340.Feb 11 2023, 1:32 PM

This update caused a lot of changes. I can't really see what up from the CHANGELOG... some theories are this, this, or this.

This will pollute Git history but I couldn't find an easy way out unfortunately

ashoat added a comment.Feb 11 2023, 1:32 PM

(All of the JS changes in this diff are irrelevant changes to import ordering and grouping)

Harbormaster completed remote builds in B16338: Diff 22340.Feb 11 2023, 1:47 PM
ashoat requested review of this revision.Feb 11 2023, 1:47 PM
atul accepted this revision.Feb 12 2023, 3:46 PM

Again checked a handful of files, but effectively accepting blind

This revision is now accepted and ready to land.Feb 12 2023, 3:46 PM
Closed by commit rCOMMa9cb552e207c: Update eslint-plugin-import to 2.27.5 (authored by ashoat). · Explain WhyFeb 12 2023, 7:46 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMa9cb552e207c: Update eslint-plugin-import to 2.27.5.

Revision Contents
Changeset List

PathSize
2 lines
120 lines

Diff 22336

View Options

package.json

Loading...
View Options

yarn.lock

Loading...