Page MenuHomePhabricator

[web] Include `primaryIdentityPublicKey` when logging in from `web`
ClosedPublic

Authored by atul on Feb 13 2023, 4:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 5:38 AM
Unknown Object (File)
Apr 3 2024, 2:18 PM
Unknown Object (File)
Apr 3 2024, 2:18 PM
Unknown Object (File)
Apr 3 2024, 2:18 PM
Unknown Object (File)
Apr 3 2024, 2:15 PM
Unknown Object (File)
Apr 3 2024, 1:53 PM
Unknown Object (File)
Mar 29 2024, 2:40 AM
Unknown Object (File)
Mar 29 2024, 2:40 AM
Subscribers
None

Details

Summary

We're now passing primaryIdentityPublicKey to logInResponder when we log in from both native and web.

Test Plan

primaryIdentityPublicKey appears in request:

8fbf6f.png (212×1 px, 65 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Feb 13 2023, 4:52 PM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.
web/account/log-in-form.react.js
28–33 ↗(On Diff #22511)

We want primaryIdentityPublicKey to be in dep list so we can re-fetch primaryIdentityPublicKey once LOG_OUT_SUCCESS gets processed and unsets primaryIdentityPublicKey.

Without these changes, primaryIdentityPublicKey would be null once LOG_OUT_SUCCESS gets processed and leaves the "Log in" button permanently disabled.

This revision is now accepted and ready to land.Feb 13 2023, 6:26 PM