Details
The DynamoDB database field for the session state is not updating when the config flag sessions.skip_authentication is used.
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
services/tunnelbroker/src/libcpp/Tunnelbroker.cpp | ||
---|---|---|
173–175 ↗ | (On Diff #22652) | Just a nitpick, I have a feeling that this check is used often across the codebase (e.g. line 185 in this file), so extracting this to a separate function would be more concise and readable: bool shouldSkipAuthentication() { return comm::network::config::ConfigManager::getInstance().isParameterSet( comm::network::config::ConfigManager:: OPTION_SESSIONS_SKIP_AUTH_KEY); } // ... if (shouldSkipAuthentication()) { return; } But totally up to you |
services/tunnelbroker/src/libcpp/Tunnelbroker.cpp | ||
---|---|---|
173–175 ↗ | (On Diff #22652) |
It's used only twice and seems that is all usage occurrences. I prefer to live it as is because adding a function will add more complexity here and more lines of code. But thanks for a good suggestion @bartek! |