Paths

Table of Contentst

Differential D6759

[lib] Set viewer's username in pending threads
ClosedPublic
Actions

Authored by ashoat on Feb 17 2023, 6:58 AM.

Tags

None

Referenced Files

	F3251232: D6759.diff
	Fri, Nov 15, 5:23 PM

	Unknown Object (File)
	Fri, Nov 1, 10:38 AM

	Unknown Object (File)
	Fri, Nov 1, 10:38 AM

	Unknown Object (File)
	Fri, Nov 1, 10:37 AM

	Unknown Object (File)
	Fri, Nov 1, 10:37 AM

	Unknown Object (File)
	Fri, Nov 1, 10:16 AM

	Unknown Object (File)
	Wed, Oct 30, 1:53 AM

	Unknown Object (File)
	Wed, Oct 30, 1:53 AM

Subscribers

Details

Reviewers

Commits

rCOMMdafc20007fe9: [lib] Set viewer's username in pending threads

Summary

Before this diff, createPendingThread would include usernames for everybody EXCEPT the viewer.

But we need to know the viewer's username so that if anybody @-tagged the viewer in the original message, then the viewer's username is properly bolded.

(We also may need to fetch an ENS name for the viewer, in case the ENS name was @-tagged.)

To make sure we always have the viewer's username available, we update createPendingThread here to take a LoggedInUserInfo instead of a viewerID.

Depends on D6758

Test Plan

In combination with diffs I haven't submitted yet, I made sure that @-mentions of the viewer get bolded in a pending sidebar

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 17 2023, 6:58 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 17 2023, 6:58 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 17 2023, 7:15 AM

Harbormaster failed remote builds in B16576: Diff 22677!

When loading a URL for a pending chat (non-sidebar) on the keyserver side, filter out any deleted users from the pending chat

ashoat added a child revision: D6760: [lib] Rename typeahead-utils.js to mention-utils.js.Feb 17 2023, 8:51 AM

Harbormaster completed remote builds in B16577: Diff 22678.Feb 17 2023, 9:03 AM

ashoat requested review of this revision.Feb 17 2023, 9:03 AM

atul accepted this revision.Feb 20 2023, 1:41 PM

This revision is now accepted and ready to land.Feb 20 2023, 1:41 PM

Closed by commit rCOMMdafc20007fe9: [lib] Set viewer's username in pending threads (authored by ashoat). · Explain WhyFeb 20 2023, 3:13 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMdafc20007fe9: [lib] Set viewer's username in pending threads.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

website-responders.js

11 lines

lib/

reducers/

message-reducer.test.js

1 line

shared/

thread-utils.js

57 lines

native/

chat/

chat-thread-list.react.js

1 line

compose-thread-button.react.js

13 lines

web/

chat/

chat-message-list-container.react.js

14 lines

Diff 22768

keyserver/src/responders/website-responders.js

Loading...

lib/reducers/message-reducer.test.js

Loading...

lib/shared/thread-utils.js

Loading...

native/chat/chat-thread-list.react.js

Loading...

native/chat/compose-thread-button.react.js

Loading...

web/chat/chat-message-list-container.react.js

Loading...