[web] Rename `setPrimaryIdentityPublicKey` to `setPrimaryIdentityKeys`
ClosedPublic
Actions

Authored by atul on Feb 23 2023, 2:15 PM.

Details

Reviewers

ashoat
tomek
marcin

Commits

rCOMM4a16ce09e722: [web] Rename `setPrimaryIdentityPublicKey` to `setPrimaryIdentityKeys`

Summary

Renaming in preparation of introducing CryptoStore to replace primaryIdentityPublicKey.

Test Plan

NA, things continue to work as expected.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 23 2023, 2:15 PM

atul published this revision for review.Feb 23 2023, 2:15 PM

Harbormaster completed remote builds in B16860: Diff 23039.Feb 23 2023, 2:27 PM

atul added a child revision: D6877: [web] Introduce `cryptoStore` to replace `primaryIdentityPublicKey` in Redux.Feb 23 2023, 6:56 PM

atul added a reviewer: marcin.Feb 24 2023, 2:21 AM

Had a thought here – we should update our sanitization code to sanitize these public keys, as they are user-identifiable. Can you create a task for that and link here before landing? (Or a diff)

This revision is now accepted and ready to land.Feb 24 2023, 8:09 AM

In D6876#204358, @ashoat wrote:

Had a thought here – we should update our sanitization code to sanitize these public keys, as they are user-identifiable. Can you create a task for that and link here before landing? (Or a diff)

https://linear.app/comm/issue/ENG-3077/[web]-sanitize-redux-cryptostore

Closed by commit rCOMM4a16ce09e722: [web] Rename `setPrimaryIdentityPublicKey` to `setPrimaryIdentityKeys` (authored by atul). · Explain WhyFeb 24 2023, 2:39 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4a16ce09e722: [web] Rename `setPrimaryIdentityPublicKey` to `setPrimaryIdentityKeys`.