[web] Update `LoginForm` `useEffect` early-exit logic to include `notificationIdentityPublicKeys`
ClosedPublic
Actions

Authored by atul on Feb 23 2023, 7:20 PM.

Details

Reviewers

ashoat
tomek
marcin

Commits

rCOMM5e9a5a925a98: [web] Update `LoginForm` `useEffect` early-exit logic to include…

Summary

Instead of just considering the primaryIdentityPublicKey, we check wither the primaryIdentityPublicKeys and notificationIdentityPublicKeys objects are set (eg not null or undefined).

Depends on D6878

Test Plan

Logged values, things were as expected.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 23 2023, 7:20 PM

atul published this revision for review.Feb 23 2023, 7:20 PM

atul edited the summary of this revision. (Show Details)

atul added a parent revision: D6878: [web] Dispatch `setNotificationIdentityKeys` in `LoginForm`.

atul added a child revision: D6880: [web] Update `primaryIdentityPublicKey[s]` selector to capture `primaryIdentityPublicKeys`.

Harbormaster completed remote builds in B16864: Diff 23043.Feb 23 2023, 7:35 PM

atul added a reviewer: marcin.Feb 24 2023, 2:21 AM

ashoat accepted this revision.Feb 24 2023, 8:15 AM

This revision is now accepted and ready to land.Feb 24 2023, 8:15 AM

Closed by commit rCOMM5e9a5a925a98: [web] Update `LoginForm` `useEffect` early-exit logic to include… (authored by atul). · Explain WhyFeb 24 2023, 2:39 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM5e9a5a925a98: [web] Update `LoginForm` `useEffect` early-exit logic to include….

Revision Contents
Changeset List

Path

Size

web/

account/

log-in-form.react.js

15 lines

Diff 23043

View Options

web/account/log-in-form.react.js

[web] Update `LoginForm` `useEffect` early-exit logic to include `notificationIdentityPublicKeys`ClosedPublicActions