[web] Ensure that `[primary/notification]IdentityPublicKeys` are set in `TraditionalLoginForm`
ClosedPublic
Actions

Authored by atul on Feb 23 2023, 9:18 PM.

Details

Reviewers

ashoat
tomek
marcin

Commits

rCOMMacbfdb96925c: [web] Ensure that `[primary/notification]IdentityPublicKeys` are set in…

Summary

Ensure that primaryIdentityPublicKeys and notificationIdentityPublicKeys are set before enabling TraditionalLoginForm. Also pass both keypairs to user-actions:logIn(...), but pull them out from restLogInInfo to ensure we don't break keyserver request input validation.

Depends on D6880

Test Plan

Still able to log in to account from both web and native.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 23 2023, 9:18 PM

atul edited the summary of this revision. (Show Details)Feb 23 2023, 9:18 PM

atul added a parent revision: D6880: [web] Update `primaryIdentityPublicKey[s]` selector to capture `primaryIdentityPublicKeys`.

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2023, 9:25 PM

Harbormaster failed remote builds in B16866: Diff 23045!

Harbormaster completed remote builds in B16866: Diff 23045.Feb 23 2023, 10:04 PM

atul requested review of this revision.Feb 23 2023, 10:04 PM

atul added a child revision: D6882: [web] Add `PickledOLMAccount`s to Redux `CryptoStore`.Feb 24 2023, 12:28 AM

atul added a reviewer: marcin.Feb 24 2023, 2:22 AM

Accepting to unblock, but not clear why we're sending primaryIdentityPublicKey up twice

web/account/traditional-login-form.react.js
87 ↗	(On Diff #23045)	Why are we still passing this in?

This revision is now accepted and ready to land.Feb 24 2023, 8:17 AM

atul added inline comments.Feb 24 2023, 1:38 PM

web/account/traditional-login-form.react.js
87 ↗	(On Diff #23045)	All the `primaryIdentityPublicKey` stuff gets ripped out in later diff. First want to get all the identity keys persisted in ServerDB and then will remove the olds stuff.