Page MenuHomePhabricator

[keyserver] Stop persisting `primaryIdentityPublicKey` from `login` request
ClosedPublic

Authored by atul on Feb 27 2023, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 23, 2:57 PM
Unknown Object (File)
Mon, Jun 17, 11:07 PM
Unknown Object (File)
Mon, Jun 17, 11:07 PM
Unknown Object (File)
Mon, Jun 17, 11:07 PM
Unknown Object (File)
Thu, Jun 13, 9:44 PM
Unknown Object (File)
Thu, Jun 13, 2:27 AM
Unknown Object (File)
Tue, Jun 11, 4:43 PM
Unknown Object (File)
Mon, Jun 3, 10:27 AM
Subscribers
None

Details

Summary

We were previously storing the primaryIdentityPublicKey in the public_key column of the cookies table. We're going to strip this logic out before DB migration that removes the public_key column altogether.

Will remove from siweAuthResponder next (and all the helper functions involved).

Test Plan
  1. Login ("traditional")
  2. Set breakpoints and observe that public_key column of cookies table isn't being set.
  3. Check cookies table make sure that most recent entry lacks public_key.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Feb 27 2023, 2:14 PM
atul retitled this revision from [keyserver] No longer persist `primaryIdentityPublicKey` from `login` request to [keyserver] Stop persisting `primaryIdentityPublicKey` from `login` request.
atul added inline comments.
keyserver/src/responders/user-responders.js
329–330 ↗(On Diff #23180)

I think this is the simplest approach. Open to thoughts/ideas/suggestions.

ashoat added inline comments.
keyserver/src/responders/user-responders.js
329–330 ↗(On Diff #23180)

This is what I'd do

This revision is now accepted and ready to land.Feb 27 2023, 2:36 PM
This revision was landed with ongoing or failed builds.Feb 27 2023, 3:32 PM
This revision was automatically updated to reflect the committed changes.