Paths

Table of Contentst

[keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`
ClosedPublic
Actions

Authored by atul on Feb 27 2023, 5:47 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMde9ea3310c90: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`

Summary

On login (for new clients), we persist signedIdentityKeysBlob in the signed_identity_keys column of the cookies table.

Next up is handling SIWE on web. Then will handle the native client. Then will add some validation regex tests just to make things a bit more robust.

Test Plan

Log in succeeds and signed_identity_keys is populated as expected when signedIdentityKeysBlob is included in login request:

Log in succeeds and signed_identity_keys is <null> when signedIdentityKeysBlob is NOT included in login request (EG old clients):

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 27 2023, 5:47 PM

atul published this revision for review.Feb 27 2023, 5:49 PM

atul edited the test plan for this revision. (Show Details)

atul attached a referenced file: F404710: 52524c.png. (Show Details)

Harbormaster completed remote builds in B16971: Diff 23207.Feb 27 2023, 6:03 PM

ashoat accepted this revision.Feb 27 2023, 7:09 PM

This revision is now accepted and ready to land.Feb 27 2023, 7:09 PM

atul mentioned this in D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.Feb 27 2023, 7:14 PM

atul added a child revision: D6909: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`.Feb 27 2023, 7:14 PM

rebase + land

This revision was landed with ongoing or failed builds.Feb 27 2023, 7:47 PM

Closed by commit rCOMMde9ea3310c90: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMde9ea3310c90: [keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `login`.

Harbormaster completed remote builds in B16977: Diff 23213.Feb 27 2023, 8:02 PM

Missed this previously

keyserver/src/session/cookies.js
650–653	This should've been made `$ReadOnly`... going forward, whenever you touch a type, please take that moment to update it

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

user-responders.js

17 lines

session/

cookies.js

8 lines

Diff 23214

View Options

keyserver/src/responders/user-responders.js