Page MenuHomePhabricator

[keyserver] Persist `signedIdentityKeysBlob` in `keyserver` on `siwe_auth`
ClosedPublic

Authored by atul on Feb 27 2023, 7:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:20 PM
Unknown Object (File)
Sun, Apr 14, 9:20 PM
Unknown Object (File)
Sun, Apr 14, 9:20 PM
Unknown Object (File)
Sun, Apr 14, 9:20 PM
Unknown Object (File)
Sun, Apr 14, 9:20 PM
Unknown Object (File)
Sun, Apr 14, 9:16 PM
Unknown Object (File)
Feb 22 2024, 9:36 AM
Unknown Object (File)
Feb 22 2024, 4:10 AM
Subscribers
None

Details

Summary

(Same as D6908, but for siwe_auth endpoint.)

On siwe_auth, we persist signedIdentityKeysBlob in the signed_identity_keys column of the cookies table.

Next up is handling login/register/siwe_auth on the native client. Then will add some validation regex tests just to make things a bit more robust.


Depends on D6908

Test Plan

siwe_auth succeeds on web and signed_identity_keys is populated as expected when signedIdentityKeysBlob is included in siwe_auth request:

6f9169.png (630×5 px, 203 KB)

(Observe that both social_proof and signed_identity_keys column are populated w/ same public key)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Feb 27 2023, 7:14 PM
atul edited the summary of this revision. (Show Details)
atul edited the test plan for this revision. (Show Details)
ashoat added inline comments.
keyserver/src/responders/user-responders.js
477 ↗(On Diff #23209)

Can we add a check to make sure this is equal to identityKeys.primaryIdentityPublicKeys.ed25519?

This revision is now accepted and ready to land.Feb 27 2023, 7:43 PM
This revision was landed with ongoing or failed builds.Feb 27 2023, 7:50 PM
This revision was automatically updated to reflect the committed changes.