Page MenuHomePhabricator
Differential D6951

[lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse]` types
ClosedPublic
Actions

Authored by atul on Mar 3 2023, 12:14 PM.
Tags
None
Referenced Files
F1789860: D6951.diff
Sun, May 19, 6:17 AM
Unknown Object (File)
Sat, May 11, 10:44 AM
Unknown Object (File)
Sat, May 11, 10:44 AM
Unknown Object (File)
Sat, May 11, 10:44 AM
Unknown Object (File)
Sat, May 11, 10:25 AM
Unknown Object (File)
Sat, May 11, 10:25 AM
Unknown Object (File)
Sat, May 11, 10:25 AM
Unknown Object (File)
Fri, May 10, 6:19 PM
View All 75 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMa6e1a2cc7b84: [lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse]` types
Summary

Add types to lib/types/request-types.js. Pretty straightforward, matched what was done for MoreOneTimeKeys.

Found the ClientServer/ServerServer/ServerClient/ClientClient naming convention to be a bit weird... but fine for now.

Test Plan

NA/flow/will be tested with subsequent diffs.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6951 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 3 2023, 12:14 PM
atul published this revision for review.Mar 3 2023, 12:14 PM
atul retitled this revision from [lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse` types to [lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse]` types.
ashoat accepted this revision.Mar 3 2023, 12:16 PM

Please wait on relevant parts of CI

This revision is now accepted and ready to land.Mar 3 2023, 12:16 PM
Harbormaster completed remote builds in B17100: Diff 23420.Mar 3 2023, 12:30 PM
atul mentioned this in D6954: [nit] Fix comment in `siweAuthResponder`.Mar 3 2023, 4:15 PM
atul updated this revision to Diff 23449.Mar 3 2023, 4:17 PM

rebase

atul updated this revision to Diff 23450.Mar 3 2023, 4:18 PM

fix typo

This revision was landed with ongoing or failed builds.Mar 3 2023, 4:20 PM
Closed by commit rCOMMa6e1a2cc7b84: [lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse]` types (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMa6e1a2cc7b84: [lib] Introduce `SignedIdentityKeysBlob[ServerRequest/ClientResponse]` types.
Harbormaster completed remote builds in B17121: Diff 23449.Mar 3 2023, 4:32 PM
Harbormaster completed remote builds in B17122: Diff 23450.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
2 lines
lib/
types/
25 lines

Diff 23450

View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

lib/types/request-types.js

Loading...