Differential D7011

[native] Return popoverLocation from useReactionSelectionPopoverPosition
ClosedPublic
Actions

Authored by ashoat on Mar 8 2023, 9:24 PM.

Details

Reviewers

ginsu

Commits

rCOMM7c524bbbe6d6: [native] Return popoverLocation from useReactionSelectionPopoverPosition

Summary

We'll need this in a later diff

Depends on D7010

Test Plan

Flow, and testing the reaction popover animation on iOS and Android release builds, including opening the emoji keyboard

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 8 2023, 9:24 PM

Herald added subscribers: atul, tomek. · View Herald TranscriptMar 8 2023, 9:24 PM

ashoat added a child revision: D7012: [native] Animate opacity and scale of ReactionSelectionPopover.Mar 8 2023, 9:24 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 8 2023, 9:39 PM

Harbormaster failed remote builds in B17198: Diff 23551!

Move Flow type changes to next diff

Harbormaster completed remote builds in B17205: Diff 23558.Mar 8 2023, 9:59 PM

ashoat requested review of this revision.Mar 8 2023, 9:59 PM

ginsu accepted this revision.Mar 9 2023, 4:31 AM

This revision is now accepted and ready to land.Mar 9 2023, 4:31 AM

Closed by commit rCOMM7c524bbbe6d6: [native] Return popoverLocation from useReactionSelectionPopoverPosition. · Explain WhyMar 9 2023, 4:46 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM7c524bbbe6d6: [native] Return popoverLocation from useReactionSelectionPopoverPosition.

Revision Contents
Changeset List

Path

Size

native/

chat/

reaction-message-utils.js

26 lines

reaction-selection-popover.react.js

12 lines

Diff 23562

View Options

native/chat/reaction-message-utils.js