Page MenuHomePhabricator

[nix] Launch `redis-server` from `REDIS_CACHE_DIR`

Authored by atul on Wed, Mar 8, 1:27 PM.
Referenced Files
Unknown Object (File)
Wed, Mar 22, 12:23 AM
Unknown Object (File)
Mon, Mar 20, 4:25 PM
Unknown Object (File)
Fri, Mar 17, 11:55 AM
Unknown Object (File)
Mon, Mar 13, 4:14 PM
Unknown Object (File)
Mon, Mar 13, 4:14 PM
Unknown Object (File)
Mon, Mar 13, 4:07 PM
Unknown Object (File)
Mon, Mar 13, 11:35 AM


Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
rCOMM8587565aae95: [nix] Launch `redis-server` from `REDIS_CACHE_DIR`

Redis will persist application files (eg dump.rdp) to disk from wherever it was launched. We're currently launching from the root of the repo, so I'm constantly getting a dump.rdp in my git working copy which is annoying (as would everyone else if they were actually using Redis/MariaDB via Nix...).

Instead we're cding to $REDIS_CACHE_DIR before launching Redis, so dump.rdp will live there and outside of the root of the repo.

Test Plan

dump.rdp appearing in $REDIS_CACHE_DIR instead of /comm after making this change + killing Redis:

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Wed, Mar 8, 1:27 PM
atul published this revision for review.Wed, Mar 8, 1:28 PM
This revision is now accepted and ready to land.Wed, Mar 8, 1:38 PM

Lol, I've added dump.rdb to .git/info/exclude to workaround this. Glad that you fixed this