Page MenuHomePhabricator
Differential D7049

[keyserver] Introduce `setCookieSignedIdentityKeysBlob`
ClosedPublic
Actions

Authored by atul on Sun, Mar 12, 3:36 PM.
Tags
None
Referenced Files
F445909: D7049.id23725.diff
Sun, Mar 26, 8:22 AM
Unknown Object (File)
Sat, Mar 25, 9:28 AM
Unknown Object (File)
Sat, Mar 25, 5:07 AM
Unknown Object (File)
Fri, Mar 24, 7:14 PM
Unknown Object (File)
Tue, Mar 21, 11:06 PM
Unknown Object (File)
Sat, Mar 18, 5:13 PM
Unknown Object (File)
Sat, Mar 18, 5:13 PM
Unknown Object (File)
Sat, Mar 18, 5:13 PM
View All 10 Files
Subscribers
None

Details

Reviewers
ashoat
Commits
rCOMMddca0507e9c1: [keyserver] Introduce `setCookieSignedIdentityKeysBlob`
Summary

Introduce setCookieSignedIdentityKeysBlob to update signed_identity_keys column of row in cookies table with id=cookieID.

This is to update serverDB when client SIGNED_IDENTITY_KEYS_BLOB response is received.

Depends on D7048

Test Plan

Ran query of that form manually in query console and it worked as expected. Will be tested implicitly by subsequent diffs in this stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Sun, Mar 12, 3:36 PM
atul edited the summary of this revision. (Show Details)Sun, Mar 12, 3:36 PM
atul added a parent revision: D7048: [web] Use `signedIdentityKeysBlobSelector` in `SIWELoginForm`.
Harbormaster completed remote builds in B17265: Diff 23653.Sun, Mar 12, 3:52 PM
atul requested review of this revision.Sun, Mar 12, 3:52 PM
atul added a child revision: D7050: [keyserver] Introduce `isCookieMissingSignedIdentityKeysBlob`.Sun, Mar 12, 4:15 PM
atul removed a reviewer: tomek.Mon, Mar 13, 7:34 AM
ashoat accepted this revision.Mon, Mar 13, 11:55 AM

I think this diff would be easier to review if you included this new function's usage in the same diff

keyserver/src/session/cookies.js
801–805 ↗(On Diff #23653)

Nit: I find SQL to be more readable this way

This revision is now accepted and ready to land.Mon, Mar 13, 11:55 AM
atul updated this revision to Diff 23725.Tue, Mar 14, 10:00 AM

address feedback

keyserver/src/session/cookies.js
801–805 ↗(On Diff #23653)

Definitely, will make that change before landing

This revision was landed with ongoing or failed builds.Tue, Mar 14, 10:03 AM
Closed by commit rCOMMddca0507e9c1: [keyserver] Introduce `setCookieSignedIdentityKeysBlob` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMddca0507e9c1: [keyserver] Introduce `setCookieSignedIdentityKeysBlob`.
Harbormaster completed remote builds in B17323: Diff 23725.Tue, Mar 14, 10:16 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
session/
14 lines

Diff 23726

View Options

keyserver/src/session/cookies.js

Loading...