Page MenuHomePhabricator

[keyserver] Introduce `setCookieSignedIdentityKeysBlob`
ClosedPublic

Authored by atul on Mar 12 2023, 3:36 PM.
Tags
None
Referenced Files
F1218059: D7049.id23653.diff
Fri, Feb 23, 10:08 AM
F1217447: D7049.id23726.diff
Fri, Feb 23, 8:42 AM
F1217440: D7049.id.diff
Fri, Feb 23, 8:40 AM
F1217357: D7049.id23725.diff
Fri, Feb 23, 8:18 AM
F1216346: D7049.diff
Fri, Feb 23, 4:57 AM
Unknown Object (File)
Wed, Feb 21, 3:33 PM
Unknown Object (File)
Wed, Feb 7, 9:41 PM
Unknown Object (File)
Wed, Feb 7, 9:40 PM
Subscribers
None

Details

Summary

Introduce setCookieSignedIdentityKeysBlob to update signed_identity_keys column of row in cookies table with id=cookieID.

This is to update serverDB when client SIGNED_IDENTITY_KEYS_BLOB response is received.


Depends on D7048

Test Plan

Ran query of that form manually in query console and it worked as expected. Will be tested implicitly by subsequent diffs in this stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Mar 12 2023, 3:52 PM

I think this diff would be easier to review if you included this new function's usage in the same diff

keyserver/src/session/cookies.js
801–805 ↗(On Diff #23653)

Nit: I find SQL to be more readable this way

This revision is now accepted and ready to land.Mar 13 2023, 11:55 AM

address feedback

keyserver/src/session/cookies.js
801–805 ↗(On Diff #23653)

Definitely, will make that change before landing

This revision was landed with ongoing or failed builds.Mar 14 2023, 10:03 AM
This revision was automatically updated to reflect the committed changes.