Page MenuHomePhabricator

[web] Use `signedIdentityKeysBlobSelector` in `SIWELoginForm`
ClosedPublic

Authored by atul on Mar 12 2023, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 23, 8:46 AM
Unknown Object (File)
Fri, Feb 23, 8:17 AM
Unknown Object (File)
Fri, Feb 23, 7:32 AM
Unknown Object (File)
Fri, Feb 23, 7:18 AM
Unknown Object (File)
Fri, Feb 23, 6:58 AM
Unknown Object (File)
Fri, Feb 23, 4:57 AM
Unknown Object (File)
Wed, Feb 21, 3:37 PM
Unknown Object (File)
Wed, Feb 7, 9:40 PM
Subscribers
None

Details

Summary

Now that we have signedIdentityKeysBlobSelector, we can use it in TraditionalLoginForm (previous diff) and SIWELoginForm to simplify things.


Depends on D7047

Test Plan
  1. Try to "SIWE" from web.

Screenshot 2023-03-12 at 5.47.45 PM.png (2×2 px, 731 KB)

  1. Set breakpoint in siweAuthResponder and make sure signedIdentityKeysBlob comes through and is validated as expected.

9308e0.png (1×4 px, 1 MB)

  1. Check the cookies table to see if signed_identity_keys column is populated correctly.

1b82fd.png (534×2 px, 142 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Mar 12 2023, 2:14 PM

update after fix + rebase

ashoat added inline comments.
web/account/siwe-login-form.react.js
77–79 ↗(On Diff #23652)

Should we get rid of this in favor of accessing the primary ed25519 key via signedIdentityKeysBlob?

This revision is now accepted and ready to land.Mar 13 2023, 11:53 AM
web/account/siwe-login-form.react.js
77–79 ↗(On Diff #23652)

I think it makes sense to grab this from Redux directly. Instead of stringifying in signedIdentityKeysBlobSelector and then parseing the primaryIdentityPublicKeys out again.