Page MenuHomePhabricator
Differential D7048

[web] Use `signedIdentityKeysBlobSelector` in `SIWELoginForm`
ClosedPublic
Actions

Authored by atul on Mar 12 2023, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 1:46 AM
Unknown Object (File)
Mon, Nov 25, 1:29 AM
Unknown Object (File)
Mon, Nov 25, 1:25 AM
Unknown Object (File)
Sun, Nov 24, 11:38 PM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
Unknown Object (File)
Sat, Nov 9, 2:26 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
Commits
rCOMMe5072ffca7f7: [web] Use `signedIdentityKeysBlobSelector` in `SIWELoginForm`
Summary

Now that we have signedIdentityKeysBlobSelector, we can use it in TraditionalLoginForm (previous diff) and SIWELoginForm to simplify things.

Depends on D7047

Test Plan
  1. Try to "SIWE" from web.

Screenshot 2023-03-12 at 5.47.45 PM.png (2×2 px, 731 KB)

  1. Set breakpoint in siweAuthResponder and make sure signedIdentityKeysBlob comes through and is validated as expected.

9308e0.png (1×4 px, 1 MB)

  1. Check the cookies table to see if signed_identity_keys column is populated correctly.

1b82fd.png (534×2 px, 142 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mar 12 2023, 2:12 PM
atul published this revision for review.Mar 12 2023, 2:14 PM
Harbormaster completed remote builds in B17262: Diff 23650.Mar 12 2023, 2:28 PM
atul updated this revision to Diff 23652.Mar 12 2023, 2:31 PM

update after fix + rebase

Harbormaster completed remote builds in B17264: Diff 23652.Mar 12 2023, 2:46 PM
atul edited the test plan for this revision. (Show Details)Mar 12 2023, 2:48 PM
atul added a child revision: D7049: [keyserver] Introduce `setCookieSignedIdentityKeysBlob`.Mar 12 2023, 3:36 PM
atul removed a reviewer: tomek.Mar 13 2023, 7:34 AM
ashoat accepted this revision.Mar 13 2023, 11:53 AM
ashoat added inline comments.
web/account/siwe-login-form.react.js
77–79 ↗(On Diff #23652)

Should we get rid of this in favor of accessing the primary ed25519 key via signedIdentityKeysBlob?

This revision is now accepted and ready to land.Mar 13 2023, 11:53 AM
atul updated this revision to Diff 23720.Mar 14 2023, 9:29 AM

rebase and land

Harbormaster completed remote builds in B17319: Diff 23720.Mar 14 2023, 9:45 AM
Closed by commit rCOMMe5072ffca7f7: [web] Use `signedIdentityKeysBlobSelector` in `SIWELoginForm` (authored by atul). · Explain WhyMar 14 2023, 9:45 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMe5072ffca7f7: [web] Use `signedIdentityKeysBlobSelector` in `SIWELoginForm`.
atul added inline comments.Mar 14 2023, 9:47 AM
web/account/siwe-login-form.react.js
77–79 ↗(On Diff #23652)

I think it makes sense to grab this from Redux directly. Instead of stringifying in signedIdentityKeysBlobSelector and then parseing the primaryIdentityPublicKeys out again.

Revision Contents
Changeset List

PathSize
web/
account/
71 lines

Diff 23724

View Options

web/account/siwe-login-form.react.js

Loading...