Page MenuHomePhabricator
Differential D7055

[native] introduce Avatar component
ClosedPublic
Actions

Authored by ginsu on Mar 12 2023, 11:06 PM.
Tags
None
Referenced Files
F3359884: D7055.diff
Sun, Nov 24, 11:33 AM
Unknown Object (File)
Fri, Nov 22, 4:24 PM
Unknown Object (File)
Sun, Nov 10, 7:32 AM
Unknown Object (File)
Sun, Nov 10, 6:54 AM
Unknown Object (File)
Tue, Nov 5, 10:16 PM
Unknown Object (File)
Tue, Nov 5, 10:16 PM
Unknown Object (File)
Tue, Nov 5, 10:15 PM
Unknown Object (File)
Tue, Nov 5, 10:15 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM0716da73f082: [native] introduce Avatar component
Summary

Introduced the Avatar component. For now, the avatar component only handles emoji avatars; however, in a subsequent diff we will extend this component to handle rendering image avatars.

This diff won't be landed until the avatars stack is all accepted

Depends on D7053

Linear Task: https://linear.app/comm/issue/ENG-3139/build-avatar-component

Test Plan

Please look at the screenshots to see the avatars rendered

Profile:

Screenshot 2023-03-13 at 1.43.52 AM.png (1×1 px, 401 KB)

Large:

Screenshot 2023-03-13 at 1.25.59 AM.png (1×952 px, 730 KB)

Small:

Screenshot 2023-03-13 at 1.26.07 AM.png (1×1 px, 733 KB)

Micro:

Screenshot 2023-03-13 at 1.24.29 AM.png (1×1 px, 740 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Mar 12 2023, 11:06 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 12 2023, 11:06 PM
ginsu edited the summary of this revision. (Show Details)Mar 12 2023, 11:10 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
ginsu attached a referenced file: F424928: Screenshot 2023-03-13 at 1.24.29 AM.png. (Show Details)
ginsu attached a referenced file: F424927: Screenshot 2023-03-13 at 1.26.07 AM.png. (Show Details)
ginsu attached a referenced file: F424926: Screenshot 2023-03-13 at 1.25.59 AM.png. (Show Details)
ginsu attached a referenced file: F424925: Screenshot 2023-03-13 at 1.43.52 AM.png. (Show Details)
ginsu edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B17272: Diff 23660.Mar 12 2023, 11:22 PM
ginsu requested review of this revision.Mar 12 2023, 11:22 PM
ginsu added a child revision: D7057: [native] render avatar in profile screen.Mar 13 2023, 1:25 AM
ashoat accepted this revision.Mar 13 2023, 9:34 AM

This is fine, but in order to unblock ENS-3302 we need to get to the point where we're actually rendering images here I think

This revision is now accepted and ready to land.Mar 13 2023, 9:34 AM
ginsu updated this revision to Diff 23849.Mar 20 2023, 7:12 AM

rebase after switching up diff stack order

ginsu edited the summary of this revision. (Show Details)Mar 20 2023, 7:12 AM
ginsu added a parent revision: D7053: [lib] introduce getAvatarForUser in avatar-utils.
ginsu removed a parent revision: D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Harbormaster completed remote builds in B17407: Diff 23849.Mar 20 2023, 7:27 AM
ginsu updated this revision to Diff 23897.Mar 20 2023, 3:23 PM

rebase before landing

Harbormaster completed remote builds in B17442: Diff 23897.Mar 20 2023, 3:38 PM
ginsu updated this revision to Diff 23929.Mar 21 2023, 8:07 AM

use new avatar types introduced by @atul

Harbormaster completed remote builds in B17470: Diff 23929.Mar 21 2023, 8:22 AM
Closed by commit rCOMM0716da73f082: [native] introduce Avatar component (authored by ginsu). · Explain WhyMar 21 2023, 8:37 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM0716da73f082: [native] introduce Avatar component.

Revision Contents
Changeset List

PathSize
native/
components/
94 lines

Diff 23849

View Options

native/components/avatar.react.js

Loading...