Page MenuHomePhabricator

[keyserver] Fix update-geoip call in Docker environment
ClosedPublic

Authored by ashoat on Mar 14 2023, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 8:53 AM
Unknown Object (File)
Fri, Apr 5, 5:44 PM
Unknown Object (File)
Sun, Mar 31, 1:19 PM
Unknown Object (File)
Sun, Mar 31, 1:19 PM
Unknown Object (File)
Sun, Mar 31, 1:17 PM
Unknown Object (File)
Fri, Mar 29, 11:10 PM
Unknown Object (File)
Mar 5 2024, 11:35 PM
Unknown Object (File)
Mar 5 2024, 11:33 PM
Subscribers

Details

Summary

yarn prod-build in keyserver is supposed to call yarn update-geoip, but this call fails in the Docker environment beacuse that call doesn't have access to the GeoIP license. This diff makes sure we forward that environment variable to the Docker build environment (instead of only being available in the production environment).

Test Plan

cd keyserver && ./bash/dc.sh up --build, with keyserver/.env populated with COMM_JSONCONFIG_secrets_geoip_license env var set. Monitor output and make sure update-geoip runs. It took about 3 minutes on my MBP, probably will take 5-6 minutes in prod

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/geoip
Lint
No Lint Coverage
Unit
No Test Coverage