Page MenuHomePhabricator

[keyserver] Fix update-geoip call in Docker environment
ClosedPublic

Authored by ashoat on Mar 14 2023, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 11:35 PM
Unknown Object (File)
Tue, Mar 5, 11:33 PM
Unknown Object (File)
Tue, Mar 5, 11:33 PM
Unknown Object (File)
Tue, Mar 5, 11:33 PM
Unknown Object (File)
Feb 22 2024, 1:04 PM
Unknown Object (File)
Feb 22 2024, 12:04 PM
Unknown Object (File)
Feb 22 2024, 6:59 AM
Unknown Object (File)
Feb 22 2024, 3:24 AM
Subscribers

Details

Summary

yarn prod-build in keyserver is supposed to call yarn update-geoip, but this call fails in the Docker environment beacuse that call doesn't have access to the GeoIP license. This diff makes sure we forward that environment variable to the Docker build environment (instead of only being available in the production environment).

Test Plan

cd keyserver && ./bash/dc.sh up --build, with keyserver/.env populated with COMM_JSONCONFIG_secrets_geoip_license env var set. Monitor output and make sure update-geoip runs. It took about 3 minutes on my MBP, probably will take 5-6 minutes in prod

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable