[keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response
ClosedPublic
Actions

Authored by atul on Mar 15 2023, 1:42 PM.

Details

Reviewers

ashoat
marcin

Commits

rCOMM734df39d7857: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response

Summary

When we receive a SIGNED_IDENTITY_KEYS_BLOB response from the client, we want to verify the signature of the payload and then update the signed_identity_keys column of the cookies row in the DB.

(I didn't know what the right approach for error-handling here was, so I'm just continueing through the loop if the signedIdentityKeysBlob object is malformed?)

Depends on D7070

Test Plan

Nuke signed_identity_keys column for all rows of cookies table:

Refresh the page on web so handleInitialClientSocketMessage gets hit on the keyserver
Observe that the web client constructs and sends a valid signedIdentityKeysBlob by setting breakpoints in keyserver:

Step through processClientResponses on the keyserver and make sure cookies table is updated as expected:

"Refresh" the native app running in iOS Simulator so handleInitialClientSocketMessage gets hit on the keyserver.
Observe that the native client constructs and sends a valid signedIdentityKeysBlob by setting breakpoints in keyserver:

Step through processClientResponses on the keyserver and make sure cookies table is updated as expected:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 15 2023, 1:42 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 15 2023, 1:42 PM

This is the last diff in the stack that I planned on putting up Monday/Tuesday, but ran into issues with D7081. Going to do some additional testing before landing to be extra careful.

atul edited the test plan for this revision. (Show Details)Mar 15 2023, 1:45 PM

ashoat accepted this revision.Mar 15 2023, 1:54 PM

ashoat added inline comments.

keyserver/src/socket/session-utils.js
213–223 ↗	(On Diff #23771)	Parts of this seem copy-pasted, wonder if it's easy to factor out

This revision is now accepted and ready to land.Mar 15 2023, 1:54 PM

Harbormaster completed remote builds in B17354: Diff 23771.Mar 15 2023, 1:57 PM

atul added inline comments.Mar 15 2023, 4:24 PM

keyserver/src/socket/session-utils.js
213–223 ↗	(On Diff #23771)	The `signedIdentityKeysBlob` verification in `user-responders` (for login/register/SIWE) can definitely be factored out since they're identical + error handling is the same. Error handling is slightly different here. I'll create a task.