Differential D7093

[native] Use a JSON blob for heightMeasurerKey
ClosedPublic
Actions

Authored by ashoat on Fri, Mar 17, 9:29 AM.

Tags

None

Referenced Files

	F444936: D7093.diff
	Sat, Mar 25, 8:56 AM

	Unknown Object (File)
	Mon, Mar 20, 12:18 PM

	Unknown Object (File)
	Mon, Mar 20, 12:18 PM

	Unknown Object (File)
	Mon, Mar 20, 3:28 AM

Subscribers

Details

Reviewers

atul
ginsu

Commits

rCOMM4765c224e781: [native] Use a JSON blob for heightMeasurerKey

Summary

Context on Linear.

Test Plan

Make sure we don't see height measurement errors when running the app on iOS simulator
Make sure that messages actually render when running the app on iOS simulator

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Fri, Mar 17, 9:29 AM

Herald added a subscriber: tomek. · View Herald TranscriptFri, Mar 17, 9:29 AM

Harbormaster completed remote builds in B17387: Diff 23823.Fri, Mar 17, 9:44 AM

ashoat requested review of this revision.Fri, Mar 17, 9:44 AM

ginsu accepted this revision.Fri, Mar 17, 11:12 AM

This revision is now accepted and ready to land.Fri, Mar 17, 11:12 AM

Closed by commit rCOMM4765c224e781: [native] Use a JSON blob for heightMeasurerKey (authored by ashoat). · Explain WhyThu, Mar 23, 8:17 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4765c224e781: [native] Use a JSON blob for heightMeasurerKey.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-item-height-measurer.react.js

6 lines

Diff 24055

native/chat/chat-item-height-measurer.react.js

Loading...