Page MenuHomePhabricator

[desktop] Stop checking for a new version after download
ClosedPublic

Authored by michal on Mar 17 2023, 11:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 12, 6:58 PM
Unknown Object (File)
Tue, Jun 11, 11:07 AM
Unknown Object (File)
Fri, May 31, 10:21 AM
Unknown Object (File)
Thu, May 30, 5:30 AM
Unknown Object (File)
Thu, May 30, 5:29 AM
Unknown Object (File)
Sun, May 26, 8:55 AM
Unknown Object (File)
Sat, May 25, 2:15 PM
Unknown Object (File)
May 10 2024, 6:04 PM
Subscribers

Details

Summary

This was the source of the issue ENG-3311, more information in the comments.
The short version is that if we checked for updates (and didn't find any) after downloading a new desktop version an error would appear when user tried to quit and update.

Test Plan

Check if the error stops happening.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'm confused – we're just deleting this? Can you provide more details on what it was supposed to do, and how that intent is handled now?

This code was supposed to handle an edge case where:

  1. Electron downloads an update, and we display the modal
  2. Before the user presses the modal to quit-and-install, we release a new version.

Without this, the user will have to update the app twice instead of once (in this rare case).

Unfortunately, this code doesn't work (and is the cause of the ENG-3311 issue). I can't think of an easy way to replace this behavior. I can make a task to replace this code with something else but I don't think it should be a priority right now.

Can you create a Linear task for handling this edge case and set it to Backlog?

This revision is now accepted and ready to land.Mar 20 2023, 2:07 PM