[lib] Introduce `*AvatarDBContent` types
ClosedPublic
Actions

Authored by atul on Mar 17 2023, 12:17 PM.

Details

Reviewers

ginsu

Commits

rCOMM4fbb34a3f4cd: [lib] Introduce `*AvatarDBContent` types

Summary

Introduce basic [Emoji/Avatar]DBContent types that will be stringified and stored in the avatar columns of the users and threads tables.

These aren't in use yet, just putting up types so Ginsu and I have the interfaces agreed upon to make implementation easier.

Test Plan

NA,

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

lib/types/avatar-types.js
11 ↗	(On Diff #23827)	This `uploadID` probably won't be used in the fetch query. Instead we'd use the `container` column of the `uploads` column to join with the `users`/`threads` table. We could separately introduce an `avatars` table?

atul published this revision for review.Mar 17 2023, 12:19 PM

atul added inline comments.

lib/types/avatar-types.js
6 ↗	(On Diff #23827)	I know we exclude the `#` elsewhere, but we end up having to pre-pend it a lot throughout our code. I think it makes sense to store with the `#`, but happy to remove to keep consistent with thread color and whatnot.

ginsu added inline comments.

lib/types/avatar-types.js
6 ↗	(On Diff #23827)	When I was working on the rendering of the avatars I was under the impression that we wouldn't have `#`. If it's not a big deal, I would prefer that we drop `#` to keep it consistent

This revision is now accepted and ready to land.Mar 17 2023, 2:16 PM

lib/types/avatar-types.js
3 ↗	(On Diff #23827)	Also nit but could we rename to `EmojiAvatarContent` I probably will have to use these types in the client and I feel like having "db types" in the client is a little strange

lib/types/avatar-types.js
3 ↗	(On Diff #23827)	The way we're going to represent avatars on the client isn't necessarily how we're going to represent them in the DB. For example, for `ImageAvatar`s on the client, we'll want `localMediaUpload` and `filePath`s instead of `uploadID`. If they end up being the same we can make `EmojiAvatarContent` an alias of `EmojiAvatarDBContent` or vice versa.
6 ↗	(On Diff #23827)	When I was working on the rendering of the avatars I was under the impression that we wouldn't have `#`. If it's not a big deal, I would prefer that we drop `#` to keep it consistent Will make that change