Page MenuHomePhabricator
Differential D7097

[lib] Introduce `*AvatarDBContent` types
ClosedPublic
Actions

Authored by atul on Mar 17 2023, 12:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 6:42 PM
Unknown Object (File)
Thu, Nov 28, 6:40 PM
Unknown Object (File)
Thu, Nov 28, 3:38 PM
Unknown Object (File)
Thu, Nov 7, 4:29 AM
Unknown Object (File)
Thu, Nov 7, 4:29 AM
Unknown Object (File)
Mon, Nov 4, 11:37 PM
Unknown Object (File)
Mon, Nov 4, 11:36 PM
Unknown Object (File)
Mon, Nov 4, 11:36 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
ginsu
Commits
rCOMM4fbb34a3f4cd: [lib] Introduce `*AvatarDBContent` types
Summary

Introduce basic [Emoji/Avatar]DBContent types that will be stringified and stored in the avatar columns of the users and threads tables.

These aren't in use yet, just putting up types so Ginsu and I have the interfaces agreed upon to make implementation easier.

Test Plan

NA,

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 17 2023, 12:17 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 17 2023, 12:17 PM
atul added inline comments.Mar 17 2023, 12:19 PM
lib/types/avatar-types.js
11

This uploadID probably won't be used in the fetch query. Instead we'd use the container column of the uploads column to join with the users/threads table.

We could separately introduce an avatars table?

atul published this revision for review.Mar 17 2023, 12:19 PM
atul added inline comments.
lib/types/avatar-types.js
6

I know we exclude the # elsewhere, but we end up having to pre-pend it a lot throughout our code. I think it makes sense to store with the #, but happy to remove to keep consistent with thread color and whatnot.

Harbormaster completed remote builds in B17391: Diff 23827.Mar 17 2023, 12:33 PM
ginsu accepted this revision.Mar 17 2023, 2:16 PM
ginsu added inline comments.
lib/types/avatar-types.js
6

When I was working on the rendering of the avatars I was under the impression that we wouldn't have #. If it's not a big deal, I would prefer that we drop # to keep it consistent

This revision is now accepted and ready to land.Mar 17 2023, 2:16 PM
ginsu added inline comments.Mar 17 2023, 3:21 PM
lib/types/avatar-types.js
3

Also nit but could we rename to EmojiAvatarContent I probably will have to use these types in the client and I feel like having "db types" in the client is a little strange

atul added inline comments.Mar 20 2023, 7:18 AM
lib/types/avatar-types.js
3

The way we're going to represent avatars on the client isn't necessarily how we're going to represent them in the DB. For example, for ImageAvatars on the client, we'll want localMediaUpload and filePaths instead of uploadID. If they end up being the same we can make EmojiAvatarContent an alias of EmojiAvatarDBContent or vice versa.

6

When I was working on the rendering of the avatars I was under the impression that we wouldn't have #. If it's not a big deal, I would prefer that we drop # to keep it consistent

Will make that change

atul updated this revision to Diff 23859.Mar 20 2023, 7:21 AM

address feedback (and sneak in ENSAvatarDBContent)

ENSAvatarDBContent will just be the type since everything else is handled on the client.

This revision was landed with ongoing or failed builds.Mar 20 2023, 7:32 AM
Closed by commit rCOMM4fbb34a3f4cd: [lib] Introduce `*AvatarDBContent` types (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM4fbb34a3f4cd: [lib] Introduce `*AvatarDBContent` types.
Harbormaster completed remote builds in B17411: Diff 23859.Mar 20 2023, 7:37 AM

Revision Contents
Changeset List

PathSize
lib/
types/
14 lines

Diff 23827

View Options

lib/types/avatar-types.js

Loading...